From: Boris Fiuczynski Date: Thu, 13 Aug 2020 14:03:44 +0000 (+0200) Subject: qemu: avoid maybe-uninitialized warning by GCC 10 X-Git-Tag: v6.7.0-rc1~122 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d96d359a032cda609f9adf3caafdf8425d8aa4ac;p=thirdparty%2Flibvirt.git qemu: avoid maybe-uninitialized warning by GCC 10 GCC 10 complains about "well_formed_uri" may be used uninitialzed. Even though it is a false positive, we can easily avoid it. Avoiding ../src/qemu/qemu_migration.c: In function ‘qemuMigrationDstPrepareDirect’: ../src/qemu/qemu_migration.c:2920:16: error: ‘well_formed_uri’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 2920 | if (well_formed_uri) { | ^ Signed-off-by: Boris Fiuczynski Reviewed-by: Marc Hartmayer Reviewed-by: Erik Skultety --- diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 0f2f92b211..142faa2cf9 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2886,7 +2886,7 @@ qemuMigrationDstPrepareDirect(virQEMUDriverPtr driver, *uri_out = g_strdup_printf(incFormat, "tcp", hostname, port); } else { - bool well_formed_uri; + bool well_formed_uri = false; if (!(uri = qemuMigrationAnyParseURI(uri_in, &well_formed_uri))) goto cleanup;