From: Christoph Fritz Date: Fri, 5 Jul 2024 09:38:44 +0000 (+0200) Subject: drm/bridge: synopsys: dw-mipi-dsi: enable EoTp by default X-Git-Tag: v6.12-rc1~126^2~24^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d97e71e449373efbd2403f1d7a32d416599f32ac;p=thirdparty%2Flinux.git drm/bridge: synopsys: dw-mipi-dsi: enable EoTp by default Enable the transmission of an EoTp (end of transmission packet) by default. EoTp should be enabled anyway because it is a Linux necessity that can be disabled by a dsi mod_flag if needed. EoTp signals the end of an HS transmission, this adds overall robustness at protocol level at the expense of an increased overhead. Signed-off-by: Christoph Fritz Reviewed-by: Robert Foss Signed-off-by: Robert Foss Link: https://patchwork.freedesktop.org/patch/msgid/6a7293bd06942131161c5a7b7878c51cfbbb807e.camel@googlemail.com --- diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index c4e9d96933dce..0fb02e4e7f4e5 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c @@ -722,7 +722,12 @@ static void dw_mipi_dsi_dpi_config(struct dw_mipi_dsi *dsi, static void dw_mipi_dsi_packet_handler_config(struct dw_mipi_dsi *dsi) { - dsi_write(dsi, DSI_PCKHDL_CFG, CRC_RX_EN | ECC_RX_EN | BTA_EN); + u32 val = CRC_RX_EN | ECC_RX_EN | BTA_EN | EOTP_TX_EN; + + if (dsi->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET) + val &= ~EOTP_TX_EN; + + dsi_write(dsi, DSI_PCKHDL_CFG, val); } static void dw_mipi_dsi_video_packet_config(struct dw_mipi_dsi *dsi,