From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 18 Apr 2023 12:34:39 +0000 (+0200)
Subject: virTypedParameterAssignValue: Drop 'copystr' parameter
X-Git-Tag: v9.4.0-rc1~137
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d9ed32bb275cf309cb092af849154e3e045753b4;p=thirdparty%2Flibvirt.git

virTypedParameterAssignValue: Drop 'copystr' parameter

All callers pass 'true'.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/util/virtypedparam.c b/src/util/virtypedparam.c
index e6ad9ec7a9..0cca16053d 100644
--- a/src/util/virtypedparam.c
+++ b/src/util/virtypedparam.c
@@ -251,7 +251,6 @@ virTypedParameterAssignValueVArgs(virTypedParameterPtr param,
 
 static int
 virTypedParameterAssignValue(virTypedParameterPtr param,
-                             bool copystr,
                              int type,
                              ...)
 {
@@ -259,7 +258,7 @@ virTypedParameterAssignValue(virTypedParameterPtr param,
     va_list ap;
 
     va_start(ap, type);
-    ret = virTypedParameterAssignValueVArgs(param, type, ap, copystr);
+    ret = virTypedParameterAssignValueVArgs(param, type, ap, true);
     va_end(ap);
 
     return ret;
@@ -785,7 +784,7 @@ virTypedParamListAddInt(virTypedParamList *list,
     int ret;
 
     if (!(par = virTypedParamListExtend(list)) ||
-        virTypedParameterAssignValue(par, true, VIR_TYPED_PARAM_INT, value) < 0)
+        virTypedParameterAssignValue(par, VIR_TYPED_PARAM_INT, value) < 0)
         return -1;
 
     va_start(ap, namefmt);
@@ -807,7 +806,7 @@ virTypedParamListAddUInt(virTypedParamList *list,
     int ret;
 
     if (!(par = virTypedParamListExtend(list)) ||
-        virTypedParameterAssignValue(par, true, VIR_TYPED_PARAM_UINT, value) < 0)
+        virTypedParameterAssignValue(par, VIR_TYPED_PARAM_UINT, value) < 0)
         return -1;
 
     va_start(ap, namefmt);
@@ -829,7 +828,7 @@ virTypedParamListAddLLong(virTypedParamList *list,
     int ret;
 
     if (!(par = virTypedParamListExtend(list)) ||
-        virTypedParameterAssignValue(par, true, VIR_TYPED_PARAM_LLONG, value) < 0)
+        virTypedParameterAssignValue(par, VIR_TYPED_PARAM_LLONG, value) < 0)
         return -1;
 
     va_start(ap, namefmt);
@@ -851,7 +850,7 @@ virTypedParamListAddULLong(virTypedParamList *list,
     int ret;
 
     if (!(par = virTypedParamListExtend(list)) ||
-        virTypedParameterAssignValue(par, true, VIR_TYPED_PARAM_ULLONG, value) < 0)
+        virTypedParameterAssignValue(par, VIR_TYPED_PARAM_ULLONG, value) < 0)
         return -1;
 
     va_start(ap, namefmt);
@@ -873,7 +872,7 @@ virTypedParamListAddString(virTypedParamList *list,
     int ret;
 
     if (!(par = virTypedParamListExtend(list)) ||
-        virTypedParameterAssignValue(par, true, VIR_TYPED_PARAM_STRING, value) < 0)
+        virTypedParameterAssignValue(par, VIR_TYPED_PARAM_STRING, value) < 0)
         return -1;
 
     va_start(ap, namefmt);
@@ -895,7 +894,7 @@ virTypedParamListAddBoolean(virTypedParamList *list,
     int ret;
 
     if (!(par = virTypedParamListExtend(list)) ||
-        virTypedParameterAssignValue(par, true, VIR_TYPED_PARAM_BOOLEAN, value) < 0)
+        virTypedParameterAssignValue(par, VIR_TYPED_PARAM_BOOLEAN, value) < 0)
         return -1;
 
     va_start(ap, namefmt);
@@ -917,7 +916,7 @@ virTypedParamListAddDouble(virTypedParamList *list,
     int ret;
 
     if (!(par = virTypedParamListExtend(list)) ||
-        virTypedParameterAssignValue(par, true, VIR_TYPED_PARAM_DOUBLE, value) < 0)
+        virTypedParameterAssignValue(par, VIR_TYPED_PARAM_DOUBLE, value) < 0)
         return -1;
 
     va_start(ap, namefmt);