From: Jonas Jelonek Date: Thu, 16 Jul 2026 22:59:40 +0000 (+0000) Subject: realtek: pcs: rtl931x: drop unused helper X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d9fdf451f17c6a642d1eec5b053a82301f72b6ce;p=thirdparty%2Fopenwrt.git realtek: pcs: rtl931x: drop unused helper Drop the unused helper rtpcs_931x_sds_reset because it is unused and - if it was used - would actively mess with the defined SerDes deactivation/activation in pcs_config. Link: https://github.com/openwrt/openwrt/pull/24310 Signed-off-by: Jonas Jelonek --- diff --git a/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c b/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c index 9da31a8bab6..bf9abc505dd 100644 --- a/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c +++ b/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c @@ -3262,30 +3262,6 @@ static int rtpcs_931x_sds_activate(struct rtpcs_serdes *sds) return rtpcs_931x_sds_power(sds, true); } -__maybe_unused -static void rtpcs_931x_sds_reset(struct rtpcs_serdes *sds) -{ - u32 o_mode, f_bit; - - /* TODO: We need to lock this! */ - - rtpcs_931x_sds_power(sds, false); - - /* save current */ - regmap_field_read(sds->swcore_regs.mac_mode, &o_mode); - regmap_field_read(sds->swcore_regs.mac_mode_force, &f_bit); - - /* force off */ - regmap_field_write(sds->swcore_regs.mac_mode, 0x1f); - regmap_field_write(sds->swcore_regs.mac_mode_force, 1); - - /* restore previous */ - regmap_field_write(sds->swcore_regs.mac_mode, o_mode); - regmap_field_write(sds->swcore_regs.mac_mode_force, f_bit); - - rtpcs_931x_sds_power(sds, true); -} - static void rtpcs_931x_sds_rx_reset(struct rtpcs_serdes *sds) { if (sds->type != RTPCS_SDS_TYPE_10G)