From: dongshengyuan <545258830@qq.com>
Date: Thu, 25 Jun 2026 08:16:40 +0000 (+0800)
Subject: sysupdate: propagate transfer_instance_vacuum() errors
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=da0252110cf04e570d558f3a8cfa30cc5741609d;p=thirdparty%2Fsystemd.git

sysupdate: propagate transfer_instance_vacuum() errors

Both vacuum loops silently return 0 on failure instead of propagating
the error code, hiding disk cleanup failures from the caller.

Signed-off-by: dongshengyuan <dongshengyuan@uniontech.com>
---

diff --git a/src/sysupdate/sysupdate-transfer.c b/src/sysupdate/sysupdate-transfer.c
index 4d698d620f7..f7e257e041a 100644
--- a/src/sysupdate/sysupdate-transfer.c
+++ b/src/sysupdate/sysupdate-transfer.c
@@ -838,7 +838,7 @@ int transfer_vacuum(
 
                 r = transfer_instance_vacuum(t, instance);
                 if (r < 0)
-                        return 0;
+                        return r;
 
                 instance_free(instance);
                 memmove(t->target.instances + i, t->target.instances + i + 1, (t->target.n_instances - i - 1) * sizeof(Instance*));
@@ -937,7 +937,7 @@ int transfer_vacuum(
 
                 r = transfer_instance_vacuum(t, oldest);
                 if (r < 0)
-                        return 0;
+                        return r;
 
                 instance_free(oldest);
                 memmove(t->target.instances + p, t->target.instances + p + 1, (t->target.n_instances - p - 1) * sizeof(Instance*));