From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Tue, 30 Mar 2021 08:26:27 +0000 (+0200)
Subject: MINOR: server: diag for 0 weight server
X-Git-Tag: v2.4-dev15~30
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=da0e7f61e0f1d0357c567592a0cfad6726b68e4d;p=thirdparty%2Fhaproxy.git

MINOR: server: diag for 0 weight server

Output a diagnostic report if a server has been configured with a null
weight.
---

diff --git a/src/server.c b/src/server.c
index dde78e8852..9043a77c2d 100644
--- a/src/server.c
+++ b/src/server.c
@@ -2702,6 +2702,10 @@ int parse_server(const char *file, int linenum, char **args,
 	if (parse_flags & SRV_PARSE_TEMPLATE)
 		_srv_parse_tmpl_init(newsrv, curproxy);
 
+	HA_DIAG_WARNING_COND(!newsrv->uweight,
+	                     "parsing [%s:%d] : 'server %s' : configured with weight of 0 will never be selected by load balancing algorithms\n",
+	                     file, linenum, newsrv->id);
+
 	return 0;
 
  out: