From: Ondřej Surý <ondrej@isc.org>
Date: Thu, 27 Feb 2020 07:45:10 +0000 (+0100)
Subject: Adjust lock/unlock in zone_rekey()
X-Git-Tag: v9.14.12~21^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=da0faf334d86d186692404bc26a858c01013b5d6;p=thirdparty%2Fbind9.git

Adjust lock/unlock in zone_rekey()

(cherry picked from commit aaaa7e67fa2b0ec618ec4be1af175fd6d73b76a0)
---

diff --git a/lib/dns/zone.c b/lib/dns/zone.c
index bfa12a27691..88f56eb4811 100644
--- a/lib/dns/zone.c
+++ b/lib/dns/zone.c
@@ -18736,10 +18736,11 @@ zone_rekey(dns_zone_t *zone) {
 
 	dns_db_closeversion(db, &ver, true);
 
+	LOCK_ZONE(zone);
+
 	if (commit) {
 		dns_difftuple_t *tuple;
 
-		LOCK_ZONE(zone);
 		DNS_ZONE_SETFLAG(zone, DNS_ZONEFLG_NEEDNOTIFY);
 
 		zone_needdump(zone, DNS_DUMP_DELAY);
@@ -18870,10 +18871,8 @@ zone_rekey(dns_zone_t *zone) {
 		 * Schedule the next resigning event
 		 */
 		set_resigntime(zone);
-		UNLOCK_ZONE(zone);
 	}
 
-	LOCK_ZONE(zone);
 	isc_time_settoepoch(&zone->refreshkeytime);
 
 	/*