From: Jeremy Allison <jra@samba.org>
Date: Fri, 3 Dec 2021 19:30:42 +0000 (-0800)
Subject: s3: smbd: filename_convert() no longer deals with wildcards.
X-Git-Tag: tdb-1.4.6~323
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=da1417fb37b88b975c22dba8276723e05f2ea282;p=thirdparty%2Fsamba.git

s3: smbd: filename_convert() no longer deals with wildcards.

These are already errored out with NT_STATUS_OBJECT_NAME_INVALID
in the unix_convert() code.

Remove the check.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/filename.c b/source3/smbd/filename.c
index e9bfbf790bf..5988396ee13 100644
--- a/source3/smbd/filename.c
+++ b/source3/smbd/filename.c
@@ -1970,7 +1970,6 @@ NTSTATUS filename_convert(TALLOC_CTX *ctx,
 			  struct smb_filename **_smb_fname)
 {
 	struct smb_filename *smb_fname = NULL;
-	bool has_wild;
 	NTSTATUS status;
 
 	*_smb_fname = NULL;
@@ -2045,14 +2044,6 @@ NTSTATUS filename_convert(TALLOC_CTX *ctx,
 		return status;
 	}
 
-	has_wild = ms_has_wild(name_in);
-	if (has_wild) {
-		DBG_DEBUG("[%s] contains wildcard, skipping pathref fsp\n",
-			  name_in);
-		*_smb_fname = smb_fname;
-		return NT_STATUS_OK;
-	}
-
 	if (!VALID_STAT(smb_fname->st)) {
 		DBG_DEBUG("[%s] does not exist, skipping pathref fsp\n",
 			  smb_fname_str_dbg(smb_fname));