From: bert hubert <bert.hubert@netherlabs.nl>
Date: Wed, 2 Mar 2016 13:58:09 +0000 (+0100)
Subject: please don't just replace atoi with pdns_stou - it does something different
X-Git-Tag: rec-4.0.0-alpha2~24^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=da21e55a429caf3d73de295c0bd72a35dbb50b76;p=thirdparty%2Fpdns.git

please don't just replace atoi with pdns_stou - it does something different
---

diff --git a/pdns/pdnsutil.cc b/pdns/pdnsutil.cc
index 4413038956..8d15e2ab47 100644
--- a/pdns/pdnsutil.cc
+++ b/pdns/pdnsutil.cc
@@ -2069,10 +2069,10 @@ seedRandom(::arg()["entropy-source"]);
       return 0;
     }
     DNSName zone(cmds[1]);
-    unsigned int id=pdns_stou(cmds[2]);
+    unsigned int id=atoi(cmds[2].c_str()); // if you make this pdns_stou, the error gets worse
     if(!id)
     {
-      cerr<<"Invalid KEY-ID"<<endl;
+      cerr<<"Invalid KEY-ID '"<<cmds[2]<<"'"<<endl;
       return 1;
     }
     if (!dk.activateKey(zone, id)) {