From: Ondrej Zajicek Date: Mon, 30 Jan 2023 22:49:20 +0000 (+0100) Subject: Babel: Improve clarity of unfeasible update handling. X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=da3624d6626c3b34bbcffb7a9acbd4aa0f6151d9;p=thirdparty%2Fbird.git Babel: Improve clarity of unfeasible update handling. Add a comment and (unnecessary) check to make correctness obvious. --- diff --git a/proto/babel/babel.c b/proto/babel/babel.c index a20bd7245..25081c3bd 100644 --- a/proto/babel/babel.c +++ b/proto/babel/babel.c @@ -1308,9 +1308,10 @@ babel_handle_update(union babel_msg *m, struct babel_iface *ifa) /* * RFC section 3.8.2.2 - Dealing with unfeasible updates. Generate a one-off - * (not retransmitted) unicast seqno request to the originator of this update + * (not retransmitted) unicast seqno request to the originator of this update. + * Note: !feasible -> s exists, check for 's' is just for clarity / safety. */ - if (!feasible && (metric != BABEL_INFINITY) && + if (!feasible && s && (metric != BABEL_INFINITY) && (!best || (r == best) || (metric < best->metric))) babel_generate_seqno_request(p, e, s->router_id, s->seqno + 1, nbr);