From: Trond Myklebust Date: Thu, 23 Oct 2014 16:33:14 +0000 (+0300) Subject: NFSv4: Ensure nfs_atomic_open set the dentry verifier on ENOENT X-Git-Tag: v3.10.107~165 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=da39d112afd21b10d71dc09c6a4dd4dfd1f96dfe;p=thirdparty%2Fkernel%2Fstable.git NFSv4: Ensure nfs_atomic_open set the dentry verifier on ENOENT commit 809fd143de8805970eec02c27c0bc2622a6ecbda upstream. If the OPEN rpc call to the server fails with an ENOENT call, nfs_atomic_open will create a negative dentry for that file, however it currently fails to call nfs_set_verifier(), thus causing the dentry to be immediately revalidated on the next call to nfs_lookup_revalidate() instead of following the usual lookup caching rules. Signed-off-by: Trond Myklebust Signed-off-by: Willy Tarreau --- diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index e093e73178b71..48038e7adb1ef 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@ -1435,6 +1435,7 @@ int nfs_atomic_open(struct inode *dir, struct dentry *dentry, switch (err) { case -ENOENT: d_add(dentry, NULL); + nfs_set_verifier(dentry, nfs_save_change_attribute(dir)); break; case -EISDIR: case -ENOTDIR: