From: Michal Privoznik <mprivozn@redhat.com>
Date: Tue, 20 Apr 2021 08:36:09 +0000 (+0200)
Subject: lxc_controller: Initialize ctrl->handshakeFd properly
X-Git-Tag: v7.3.0-rc1~58
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=da61e92739b16bb9403f94b5a5e64fe728d7bbe9;p=thirdparty%2Flibvirt.git

lxc_controller: Initialize ctrl->handshakeFd properly

The lxc_controller has a structure that's keeping its internal
state, including so called handshakeFd which is the write end of
a pipe that's used to signal to the LXC driver that the container
is set up and ready to run. However, the struct member is not
initialized to -1, so if anything fails before it is set then the
virLXCControllerFree() function tries to close FD 0 (stdin).

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
index ab5fc8b88f..50b2987d9a 100644
--- a/src/lxc/lxc_controller.c
+++ b/src/lxc/lxc_controller.c
@@ -193,8 +193,8 @@ static virLXCController *virLXCControllerNew(const char *name)
 
     ctrl->timerShutdown = -1;
     ctrl->firstClient = true;
-
     ctrl->name = g_strdup(name);
+    ctrl->handshakeFd = -1;
 
     if (!(driver = virLXCControllerDriverNew()))
         goto error;