From: Stephan Bosch Date: Fri, 25 Sep 2020 01:22:45 +0000 (+0200) Subject: lib-smtp: smtp-client-transaction - Make smtp_client_transaction_mail_fail_reply... X-Git-Tag: 2.3.18~126 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=da73aac321f7ec877ea7a60bbbb984837adc3649;p=thirdparty%2Fdovecot%2Fcore.git lib-smtp: smtp-client-transaction - Make smtp_client_transaction_mail_fail_reply(NULL, reply) a no-op. --- diff --git a/src/lib-smtp/smtp-client-transaction.c b/src/lib-smtp/smtp-client-transaction.c index a070a35c7e..9333335724 100644 --- a/src/lib-smtp/smtp-client-transaction.c +++ b/src/lib-smtp/smtp-client-transaction.c @@ -134,6 +134,11 @@ smtp_client_transaction_mail_fail_reply( const struct smtp_reply *reply) { struct smtp_client_transaction_mail *mail = *_mail; + + if (mail == NULL) + return; + *_mail = NULL; + smtp_client_command_callback_t *callback = mail->mail_callback; void *context = mail->context; @@ -142,7 +147,7 @@ smtp_client_transaction_mail_fail_reply( if (callback != NULL) callback(reply, context); - smtp_client_transaction_mail_free(_mail); + smtp_client_transaction_mail_free(&mail); } /*