From: Alan T. DeKok Date: Sat, 13 Jul 2019 14:53:25 +0000 (+0200) Subject: goto exit on success, not error X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=da786cbc4c440ae3ee3eba90a126371e88fa8948;p=thirdparty%2Ffreeradius-server.git goto exit on success, not error --- diff --git a/src/modules/proto_control/radmin.c b/src/modules/proto_control/radmin.c index e0849d2faca..3f9fb31124b 100644 --- a/src/modules/proto_control/radmin.c +++ b/src/modules/proto_control/radmin.c @@ -833,7 +833,7 @@ int main(int argc, char **argv) if ((cf_file_read(cs, io_buffer) < 0) || (cf_section_pass2(cs) < 0)) { fprintf(stderr, "%s: Errors reading or parsing %s\n", progname, io_buffer); - error: + error: exit(EXIT_FAILURE); } @@ -955,7 +955,10 @@ int main(int argc, char **argv) while (true) flush_conduits(sockfd, io_buffer, sizeof(io_buffer)); } - goto error; + /* + * We're done all of the commands, exit now. + */ + goto exit; } if (!quiet) {