From: 三咲智子 Kevin Deng <sxzz@sxzz.moe>
Date: Wed, 29 Nov 2023 14:09:46 +0000 (+0800)
Subject: refactor: use enum
X-Git-Tag: v3.6.0-alpha.1~16^2~788
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=da931ea942c55ab5853ef6c4fa5e781956278389;p=thirdparty%2Fvuejs%2Fcore.git

refactor: use enum
---

diff --git a/packages/compiler-vapor/src/errors.ts b/packages/compiler-vapor/src/errors.ts
index f89c23297f..4f89b5eadc 100644
--- a/packages/compiler-vapor/src/errors.ts
+++ b/packages/compiler-vapor/src/errors.ts
@@ -10,7 +10,7 @@ export function defaultOnWarn(msg: CompilerError) {
   __DEV__ && console.warn(`[Vue warn] ${msg.message}`)
 }
 
-export const enum ErrorCodes {
+export enum ErrorCodes {
   // transform errors
   VAPOR_BIND_NO_EXPRESSION,
   VAPOR_ON_NO_EXPRESSION,
diff --git a/packages/compiler-vapor/src/ir.ts b/packages/compiler-vapor/src/ir.ts
index 136f11fc06..b3892a3cdd 100644
--- a/packages/compiler-vapor/src/ir.ts
+++ b/packages/compiler-vapor/src/ir.ts
@@ -1,6 +1,6 @@
 import type { SourceLocation } from '@vue/compiler-dom'
 
-export const enum IRNodeTypes {
+export enum IRNodeTypes {
   ROOT,
   TEMPLATE_FACTORY,
   FRAGMENT_FACTORY,
diff --git a/packages/compiler-vapor/src/transform.ts b/packages/compiler-vapor/src/transform.ts
index 97c105d19d..d7f5b7f1ad 100644
--- a/packages/compiler-vapor/src/transform.ts
+++ b/packages/compiler-vapor/src/transform.ts
@@ -1,14 +1,14 @@
-import type {
+import {
+  type RootNode,
+  type Node,
+  type TemplateChildNode,
+  type ElementNode,
+  type AttributeNode,
+  type InterpolationNode,
+  type TransformOptions,
+  type DirectiveNode,
+  type ExpressionNode,
   NodeTypes,
-  RootNode,
-  Node,
-  TemplateChildNode,
-  ElementNode,
-  AttributeNode,
-  InterpolationNode,
-  TransformOptions,
-  DirectiveNode,
-  ExpressionNode,
 } from '@vue/compiler-dom'
 import {
   type OperationNode,
@@ -235,19 +235,19 @@ function transformChildren(
     const isLast = index === children.length - 1
 
     switch (node.type) {
-      case 1 satisfies NodeTypes.ELEMENT: {
+      case NodeTypes.ELEMENT: {
         transformElement(child as TransformContext<ElementNode>)
         break
       }
-      case 2 satisfies NodeTypes.TEXT: {
+      case NodeTypes.TEXT: {
         child.template += node.content
         break
       }
-      case 3 satisfies NodeTypes.COMMENT: {
+      case NodeTypes.COMMENT: {
         child.template += `<!--${node.content}-->`
         break
       }
-      case 5 satisfies NodeTypes.INTERPOLATION: {
+      case NodeTypes.INTERPOLATION: {
         transformInterpolation(
           child as TransformContext<InterpolationNode>,
           isFirst,
@@ -255,7 +255,7 @@ function transformChildren(
         )
         break
       }
-      case 12 satisfies NodeTypes.TEXT_CALL:
+      case NodeTypes.TEXT_CALL:
         // never?
         break
       default: {
@@ -305,7 +305,7 @@ function transformInterpolation(
 ) {
   const { node } = ctx
 
-  if (node.content.type === (8 satisfies NodeTypes.COMPOUND_EXPRESSION)) {
+  if (node.content.type === NodeTypes.COMPOUND_EXPRESSION) {
     // TODO: CompoundExpressionNode: {{ count + 1 }}
     return
   }
@@ -345,7 +345,7 @@ function transformProp(
 ): void {
   const { name } = node
 
-  if (node.type === (6 satisfies NodeTypes.ATTRIBUTE)) {
+  if (node.type === NodeTypes.ATTRIBUTE) {
     if (node.value) {
       ctx.template += ` ${name}="${node.value.content}"`
     } else {
@@ -361,8 +361,7 @@ function transformProp(
     case 'bind': {
       if (
         !exp ||
-        (exp.type === (4 satisfies NodeTypes.SIMPLE_EXPRESSION) &&
-          !exp.content.trim())
+        (exp.type === NodeTypes.SIMPLE_EXPRESSION && !exp.content.trim())
       ) {
         ctx.options.onError!(
           createCompilerError(ErrorCodes.VAPOR_BIND_NO_EXPRESSION, loc),
@@ -377,9 +376,7 @@ function transformProp(
       } else if (!node.arg) {
         // TODO support v-bind="{}"
         return
-      } else if (
-        node.arg.type === (8 satisfies NodeTypes.COMPOUND_EXPRESSION)
-      ) {
+      } else if (node.arg.type === NodeTypes.COMPOUND_EXPRESSION) {
         // TODO support :[foo]="bar"
         return
       }
@@ -404,9 +401,7 @@ function transformProp(
       if (!node.arg) {
         // TODO support v-on="{}"
         return
-      } else if (
-        node.arg.type === (8 satisfies NodeTypes.COMPOUND_EXPRESSION)
-      ) {
+      } else if (node.arg.type === NodeTypes.COMPOUND_EXPRESSION) {
         // TODO support @[foo]="bar"
         return
       } else if (expr === null) {
@@ -461,7 +456,7 @@ function processExpression(
   expr: ExpressionNode | undefined,
 ): string | null {
   if (!expr) return null
-  if (expr.type === (8 satisfies NodeTypes.COMPOUND_EXPRESSION)) {
+  if (expr.type === NodeTypes.COMPOUND_EXPRESSION) {
     // TODO
     return ''
   }