From: Ján Tomko Date: Tue, 12 Oct 2021 13:31:22 +0000 (+0200) Subject: qemu: correctly pass qemuBuildVHostUserFsDevProps X-Git-Tag: v7.9.0-rc1~123 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=daa8d3220d7700c9f3755011405b305359066de6;p=thirdparty%2Flibvirt.git qemu: correctly pass qemuBuildVHostUserFsDevProps ../../work/libvirt/src/qemu/qemu_hotplug.c: In function ‘qemuDomainAttachFSDevice’: ../../work/libvirt/src/qemu/qemu_hotplug.c:3458:68: error: ordered comparison of pointer with integer zero [-Werror=extra] 3458 | if (qemuBuildVHostUserFsDevProps(fs, vm->def, charAlias, priv) < 0) | ^ cc1: all warnings being treated as errors Fixes: b98787303498cfb8426ab27ee62247b164101242 Signed-off-by: Ján Tomko --- diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index b113a5bc1e..af49e58f8e 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -3455,7 +3455,7 @@ qemuDomainAttachFSDevice(virQEMUDriver *driver, charAlias = qemuDomainGetVhostUserChrAlias(fs->info.alias); - if (qemuBuildVHostUserFsDevProps(fs, vm->def, charAlias, priv) < 0) + if (!(devprops = qemuBuildVHostUserFsDevProps(fs, vm->def, charAlias, priv))) goto cleanup; if (!fs->sock) {