From: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Date: Fri, 3 Oct 2025 02:14:00 +0000 (+1300)
Subject: s4:kdc: Move talloc_steal() back to function end
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dab9b41bf7f896a1198a1df4de7ee9172e849213;p=thirdparty%2Fsamba.git

s4:kdc: Move talloc_steal() back to function end

Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/source4/kdc/db-glue.c b/source4/kdc/db-glue.c
index 562112059f2..80915f2c99c 100644
--- a/source4/kdc/db-glue.c
+++ b/source4/kdc/db-glue.c
@@ -2641,12 +2641,6 @@ static krb5_error_code samba_kdc_message2entry(krb5_context context,
 		 */
 	}
 
-	p->msg = talloc_steal(p, msg);
-	p->supported_enctypes = pa_supported_enctypes;
-
-	p->client_policy = talloc_steal(p, authn_client_policy);
-	p->server_policy = talloc_steal(p, authn_server_policy);
-
 	ret = get_key_trust_public_keys(tmp_ctx, kdc_db_ctx->samdb, msg, entry);
 	if (ret != 0) {
 		goto out;
@@ -2657,6 +2651,12 @@ static krb5_error_code samba_kdc_message2entry(krb5_context context,
 		goto out;
 	}
 
+	p->msg = talloc_steal(p, msg);
+	p->supported_enctypes = pa_supported_enctypes;
+
+	p->client_policy = talloc_steal(p, authn_client_policy);
+	p->server_policy = talloc_steal(p, authn_server_policy);
+
 	talloc_steal(kdc_db_ctx, p);
 
 out: