From: Guenter Roeck Date: Sat, 25 Jun 2011 19:42:14 +0000 (-0700) Subject: hwmon: (pmbus) Drop check for PMBus revision register in probe function X-Git-Tag: v2.6.39.4~64 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dad44d6aa368ded6f12f534eb0a61c9275b10548;p=thirdparty%2Fkernel%2Fstable.git hwmon: (pmbus) Drop check for PMBus revision register in probe function commit 7f2c0662e5cfd05f12ca49109e8f787bf2d87b66 upstream. Some PMBus devices do not support the PMBus revision register, so don't check if it exists. Signed-off-by: Guenter Roeck Reviewed-by: Robert Coulson Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/hwmon/pmbus_core.c b/drivers/hwmon/pmbus_core.c index 7df490ec55fa9..7b8d8a6331289 100644 --- a/drivers/hwmon/pmbus_core.c +++ b/drivers/hwmon/pmbus_core.c @@ -1518,14 +1518,9 @@ int pmbus_do_probe(struct i2c_client *client, const struct i2c_device_id *id, i2c_set_clientdata(client, data); mutex_init(&data->update_lock); - /* - * Bail out if status register or PMBus revision register - * does not exist. - */ - if (i2c_smbus_read_byte_data(client, PMBUS_STATUS_BYTE) < 0 - || i2c_smbus_read_byte_data(client, PMBUS_REVISION) < 0) { - dev_err(&client->dev, - "Status or revision register not found\n"); + /* Bail out if PMBus status register does not exist. */ + if (i2c_smbus_read_byte_data(client, PMBUS_STATUS_BYTE) < 0) { + dev_err(&client->dev, "PMBus status register not found\n"); ret = -ENODEV; goto out_data; }