From: Ville Syrjälä Date: Mon, 24 Feb 2025 17:30:17 +0000 (+0200) Subject: drm/i915: Fix pipeDMC and ATS fault handling X-Git-Tag: v6.15-rc1~120^2~9^2~90 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=db0d2d7572153490449e360d5ebf298badf5f395;p=thirdparty%2Fkernel%2Flinux.git drm/i915: Fix pipeDMC and ATS fault handling The fault handler is supposed to return true when it handles the fault. The pipeDMC and ATS handlers are returning false instead which results in the "unreported faults" WARN triggering when it shouldn't. Fixes: f13011a79999 ("drm/i915: Pimp display fault reporting") Signed-off-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20250224173017.29500-1-ville.syrjala@linux.intel.com Reviewed-by: Vinod Govindapillai --- diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c b/drivers/gpu/drm/i915/display/intel_display_irq.c index 99fb7fc7be394..aa23bb8178053 100644 --- a/drivers/gpu/drm/i915/display/intel_display_irq.c +++ b/drivers/gpu/drm/i915/display/intel_display_irq.c @@ -1101,7 +1101,7 @@ static bool handle_plane_ats_fault(struct intel_crtc *crtc, enum plane_id plane_ "[CRTC:%d:%s] PLANE ATS fault\n", crtc->base.base.id, crtc->base.name); - return false; + return true; } static bool handle_pipedmc_ats_fault(struct intel_crtc *crtc, enum plane_id plane_id) @@ -1112,7 +1112,7 @@ static bool handle_pipedmc_ats_fault(struct intel_crtc *crtc, enum plane_id plan "[CRTC:%d:%s] PIPEDMC ATS fault\n", crtc->base.base.id, crtc->base.name); - return false; + return true; } static bool handle_pipedmc_fault(struct intel_crtc *crtc, enum plane_id plane_id) @@ -1123,7 +1123,7 @@ static bool handle_pipedmc_fault(struct intel_crtc *crtc, enum plane_id plane_id "[CRTC:%d:%s] PIPEDMC fault\n", crtc->base.base.id, crtc->base.name); - return false; + return true; } static const struct pipe_fault_handler mtl_pipe_fault_handlers[] = {