From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Mon, 12 Feb 2024 08:26:43 +0000 (+0200)
Subject: lib-index: Do update log_file_tail_offset on sync if mail_transaction_log_view_next... 
X-Git-Tag: 2.4.2~71
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=db209167c67933d525e01bc45c4c0061e9f335dc;p=thirdparty%2Fdovecot%2Fcore.git

lib-index: Do update log_file_tail_offset on sync if mail_transaction_log_view_next() fails

The previous change assumed that mail_transaction_log_view_next() would
return -1 on read() error. However, it's actually returning -1 to indicate
a corrupted record.

Reverts aae93d3ea73004ba1883bbf91c9e40f613ffc857
---

diff --git a/src/lib-index/mail-index-sync-update.c b/src/lib-index/mail-index-sync-update.c
index 6bf30971e2..622e6ab747 100644
--- a/src/lib-index/mail-index-sync-update.c
+++ b/src/lib-index/mail-index-sync-update.c
@@ -1041,8 +1041,7 @@ int mail_index_sync_map(struct mail_index_map **_map,
 	   over following external transactions to avoid extra unneeded log
 	   reading. */
 	i_assert(map->hdr.log_file_seq == index->log->head->hdr.file_seq);
-	if (ret == 0 &&
-	    map->hdr.log_file_tail_offset < index->log->head->max_tail_offset) {
+	if (map->hdr.log_file_tail_offset < index->log->head->max_tail_offset) {
 		map->hdr.log_file_tail_offset =
 			index->log->head->max_tail_offset;
 	}