From: Christopher Faulet <cfaulet@haproxy.com>
Date: Thu, 15 Oct 2020 15:19:46 +0000 (+0200)
Subject: BUG/MEDIUM: mux-h1: Get the session from the H1S when capturing bad messages
X-Git-Tag: v2.3-dev7~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=db2c17da60e80091615ddbe8d97cb964d1f00ac7;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: mux-h1: Get the session from the H1S when capturing bad messages

It is not guaranteed that the backend connection has an owner. It is set when
the connection is created. But when the connection is moved in a server idle
list, the connection owner is set to NULL and may never be set again. On the
other hand, when a mux is created or when a CS is attached, the session is
always defined. The H1 stream always keep a reference on it when it is
created. Thus, when a bad message is captured we should not rely on the
connection owner to retrieve the session. Instead we should get it from the H1
stream.
---

diff --git a/src/mux_h1.c b/src/mux_h1.c
index 23cc72f1f1..6e85b129be 100644
--- a/src/mux_h1.c
+++ b/src/mux_h1.c
@@ -1079,7 +1079,7 @@ static void h1_show_error_snapshot(struct buffer *out, const struct error_snapsh
 static void h1_capture_bad_message(struct h1c *h1c, struct h1s *h1s,
 				   struct h1m *h1m, struct buffer *buf)
 {
-	struct session *sess = h1c->conn->owner;
+	struct session *sess = h1s->sess;
 	struct proxy *proxy = h1c->px;
 	struct proxy *other_end;
 	union error_snapshot_ctx ctx;