From: James Jones <jejones3141@gmail.com>
Date: Wed, 30 Dec 2020 15:06:28 +0000 (-0600)
Subject: Pass &vp to radius_pairmove() rather than vp in add_vp_tuple() (#3821)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=db65afe8b24c29b509fd7325439b33722b503f26;p=thirdparty%2Ffreeradius-server.git

Pass &vp to radius_pairmove() rather than vp in add_vp_tuple() (#3821)

This doesn't include code testing rlm_mruby, but it is consistent
with the prototype of radius_pairmove() and with other uses of
the function (e.g. in mod_vptuple() in rlm_python/rlm_python.c).
---

diff --git a/src/modules/rlm_mruby/rlm_mruby.c b/src/modules/rlm_mruby/rlm_mruby.c
index 8e770c063fe..9f77583d8c6 100644
--- a/src/modules/rlm_mruby/rlm_mruby.c
+++ b/src/modules/rlm_mruby/rlm_mruby.c
@@ -379,7 +379,7 @@ static void add_vp_tuple(TALLOC_CTX *ctx, request_t *request, fr_pair_list_t *vp
 			DEBUG("%s: %s %s %s OK", function_name, ckey, fr_table_str_by_value(fr_tokens_table, op, "="), cval);
 		}
 
-		radius_pairmove(request, vps, vp, false);
+		radius_pairmove(request, vps, &vp, false);
 	}
 }