From: James Jones Date: Wed, 21 Sep 2022 13:53:39 +0000 (-0500) Subject: Annotate calls we know won't fail (CID #1503939) (#4722) X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dba4b6b0dbdab438969ed61107740fdc174a5860;p=thirdparty%2Ffreeradius-server.git Annotate calls we know won't fail (CID #1503939) (#4722) The individual tests in edit_tests all operate on a three-element pair list they get from add_pairs(), freeing it after they're done. fr_pair_afrom_da() only returns NULL if it runs out of memory-- unlikely in this context, so we annotate the calls that add items to the list. --- diff --git a/src/lib/util/edit_tests.c b/src/lib/util/edit_tests.c index ca116dc520a..836071d3053 100644 --- a/src/lib/util/edit_tests.c +++ b/src/lib/util/edit_tests.c @@ -85,8 +85,11 @@ static void add_pairs(fr_pair_list_t *local_pairs) fr_pair_list_init(local_pairs); + /* coverity[dereference] */ fr_pair_append(local_pairs, fr_pair_afrom_da(autofree, fr_dict_attr_test_uint32)); + /* coverity[dereference] */ fr_pair_append(local_pairs, fr_pair_afrom_da(autofree, fr_dict_attr_test_octets)); + /* coverity[dereference] */ fr_pair_append(local_pairs, fr_pair_afrom_da(autofree, fr_dict_attr_test_tlv)); count = fr_pair_list_num_elements(local_pairs);