From: Dmitry V. Levin <ldv@altlinux.org>
Date: Wed, 27 Dec 2017 22:12:51 +0000 (+0000)
Subject: elf: check for rpath emptiness before making a copy of it
X-Git-Tag: glibc-2.27~204
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dbba87d531ad3ea372eba6cb56436a231ca7fb32;p=thirdparty%2Fglibc.git

elf: check for rpath emptiness before making a copy of it

* elf/dl-load.c (decompose_rpath): Check for rpath emptiness before
making a copy of it.
---

diff --git a/ChangeLog b/ChangeLog
index 22a4a9f5577..1dd4b86de20 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2018-01-01  Dmitry V. Levin  <ldv@altlinux.org>
+
+	* elf/dl-load.c (decompose_rpath): Check for rpath emptiness before
+	making a copy of it.
+
 2018-01-01  Joseph Myers  <joseph@codesourcery.com>
 
 	* manual/texinfo.tex: Update to version 2017-12-26.21 with
diff --git a/elf/dl-load.c b/elf/dl-load.c
index d9ec49d15e7..7554a99b5ac 100644
--- a/elf/dl-load.c
+++ b/elf/dl-load.c
@@ -499,7 +499,6 @@ decompose_rpath (struct r_search_path_struct *sps,
 {
   /* Make a copy we can work with.  */
   const char *where = l->l_name;
-  char *copy;
   char *cp;
   struct r_search_path_elem **result;
   size_t nelems;
@@ -538,22 +537,21 @@ decompose_rpath (struct r_search_path_struct *sps,
       while (*inhp != '\0');
     }
 
+  /* Ignore empty rpaths.  */
+  if (*rpath == '\0')
+    {
+      sps->dirs = (struct r_search_path_elem **) -1;
+      return false;
+    }
+
   /* Make a writable copy.  */
-  copy = __strdup (rpath);
+  char *copy = __strdup (rpath);
   if (copy == NULL)
     {
       errstring = N_("cannot create RUNPATH/RPATH copy");
       goto signal_error;
     }
 
-  /* Ignore empty rpaths.  */
-  if (*copy == 0)
-    {
-      free (copy);
-      sps->dirs = (struct r_search_path_elem **) -1;
-      return false;
-    }
-
   /* Count the number of necessary elements in the result array.  */
   nelems = 0;
   for (cp = copy; *cp != '\0'; ++cp)