From: bugreport%peshkin.net <>
Date: Sat, 10 Jul 2004 14:35:34 +0000 (+0000)
Subject: Bug 227191: Change DBI->connect syntax so database password will not be revealed... 
X-Git-Tag: bugzilla-2.18rc1~10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dbce51e838e74f1ad31e3d8076db93df64f56592;p=thirdparty%2Fbugzilla.git

Bug 227191: Change DBI->connect syntax so database password will not be revealed if connect fails
r=bbaetz
a=justdave
---

diff --git a/Bugzilla/DB.pm b/Bugzilla/DB.pm
index a766a6e04b..445e29500d 100644
--- a/Bugzilla/DB.pm
+++ b/Bugzilla/DB.pm
@@ -144,10 +144,12 @@ sub _connect {
     # connect using our known info to the specified db
     # Apache::DBI will cache this when using mod_perl
     my $dbh = DBI->connect($dsn,
-                           $db_user,
-                           $db_pass,
+                           '',
+                           '',
                            { RaiseError => 1,
                              PrintError => 0,
+                             Username => $db_user,
+                             Password => $db_pass,
                              ShowErrorStatement => 1,
                              HandleError => \&_handle_error,
                              FetchHashKeyName => 'NAME_lc',
diff --git a/checksetup.pl b/checksetup.pl
index c9ced42ecf..2ccf0d8a4d 100755
--- a/checksetup.pl
+++ b/checksetup.pl
@@ -246,7 +246,7 @@ my $modules = [
     }, 
     { 
         name => 'DBI', 
-        version => '1.32' 
+        version => '1.36' 
     }, 
     { 
         name => 'DBD::mysql',