From: Eduardo San Martin Morote <posva13@gmail.com>
Date: Tue, 27 Dec 2022 13:00:29 +0000 (+0100)
Subject: chore: note about beforeunload
X-Git-Tag: v4.2.0~68
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dbd0bc6bd2d1f0c1c7a88a8497f1276433816877;p=thirdparty%2Fvuejs%2Frouter.git

chore: note about beforeunload
---

diff --git a/packages/router/src/history/html5.ts b/packages/router/src/history/html5.ts
index bc4531f9..6aeda01a 100644
--- a/packages/router/src/history/html5.ts
+++ b/packages/router/src/history/html5.ts
@@ -144,7 +144,11 @@ function useHistoryListeners(
 
   // set up the listeners and prepare teardown callbacks
   window.addEventListener('popstate', popStateHandler)
-  window.addEventListener('beforeunload', beforeUnloadListener)
+  // TODO: could we use 'pagehide' or 'visibilitychange' instead?
+  // https://developer.chrome.com/blog/page-lifecycle-api/
+  window.addEventListener('beforeunload', beforeUnloadListener, {
+    passive: true,
+  })
 
   return {
     pauseListeners,