From: Liu Xinpeng Date: Tue, 26 Apr 2022 14:53:30 +0000 (+0800) Subject: watchdog: wdat_wdt: Stop watchdog when uninstalling module X-Git-Tag: v5.15.198~439 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dbe2bb24ac4c1827b3a09588224b837c07279ecc;p=thirdparty%2Fkernel%2Fstable.git watchdog: wdat_wdt: Stop watchdog when uninstalling module [ Upstream commit 330415ebea81b65842e4cc6d2fd985c1b369e650 ] Test shows that wachdog still reboots machine after the module is removed. Use watchdog_stop_on_unregister to stop the watchdog on removing. Signed-off-by: Liu Xinpeng eviewed-by: Guenter Roeck Link: https://lore.kernel.org/r/1650984810-6247-4-git-send-email-liuxp11@chinatelecom.cn Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck Stable-dep-of: 25c0b472eab8 ("watchdog: wdat_wdt: Fix ACPI table leak in probe function") Signed-off-by: Sasha Levin --- diff --git a/drivers/watchdog/wdat_wdt.c b/drivers/watchdog/wdat_wdt.c index 4fac8148a8e62..51cd99428940a 100644 --- a/drivers/watchdog/wdat_wdt.c +++ b/drivers/watchdog/wdat_wdt.c @@ -463,6 +463,7 @@ static int wdat_wdt_probe(struct platform_device *pdev) watchdog_set_nowayout(&wdat->wdd, nowayout); watchdog_stop_on_reboot(&wdat->wdd); + watchdog_stop_on_unregister(&wdat->wdd); return devm_watchdog_register_device(dev, &wdat->wdd); }