From: Ján Tomko <jtomko@redhat.com>
Date: Tue, 22 Sep 2020 20:19:26 +0000 (+0200)
Subject: virsh: do not return bool in virshNetworkPortUUIDCompleter
X-Git-Tag: v6.8.0-rc1~57
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dbe3cf6c64a38c571062557770d64fed837f9c3d;p=thirdparty%2Flibvirt.git

virsh: do not return bool in virshNetworkPortUUIDCompleter

portability: Returning an integer in a function with pointer
return type is not portable. [CastIntegerToAddressAtReturn]

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/tools/virsh-completer-network.c b/tools/virsh-completer-network.c
index a63d657477..73f7115ab2 100644
--- a/tools/virsh-completer-network.c
+++ b/tools/virsh-completer-network.c
@@ -103,7 +103,7 @@ virshNetworkPortUUIDCompleter(vshControl *ctl,
         return NULL;
 
     if (!(net = virshCommandOptNetwork(ctl, cmd, NULL)))
-        return false;
+        return NULL;
 
     if ((nports = virNetworkListAllPorts(net, &ports, flags)) < 0)
         return NULL;