From: James King <t.james.king@gmail.com>
Date: Tue, 1 Apr 2008 19:17:36 +0000 (+0200)
Subject: [IPTABLES]: libxt_iprange: Fix IP validation logic
X-Git-Tag: v1.4.1-rc1~42
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dbe6c3b74ee847707181f1fe28b2975b4a8ab425;p=thirdparty%2Fiptables.git

[IPTABLES]: libxt_iprange: Fix IP validation logic

IP address validation logic was inverted, causing valid addresses to
be rejected.

Signed-off-by: James King <t.james.king@gmail.com>
---

diff --git a/extensions/libxt_iprange.c b/extensions/libxt_iprange.c
index 51b35f8a..c4fe7cfc 100644
--- a/extensions/libxt_iprange.c
+++ b/extensions/libxt_iprange.c
@@ -41,14 +41,14 @@ parse_iprange(char *arg, struct ipt_iprange *range)
 		*dash = '\0';
 
 	ip = numeric_to_ipaddr(arg);
-	if (ip != NULL)
+	if (!ip)
 		exit_error(PARAMETER_PROBLEM, "iprange match: Bad IP address `%s'\n",
 			   arg);
 	range->min_ip = ip->s_addr;
 
 	if (dash != NULL) {
 		ip = numeric_to_ipaddr(dash+1);
-		if (ip != NULL)
+		if (!ip)
 			exit_error(PARAMETER_PROBLEM, "iprange match: Bad IP address `%s'\n",
 				   dash+1);
 		range->max_ip = ip->s_addr;