From: Theodore Ts'o <tytso@mit.edu>
Date: Fri, 1 Nov 2013 03:00:24 +0000 (-0400)
Subject: ext4: avoid bh leak in retry path of ext4_expand_extra_isize_ea()
X-Git-Tag: v3.4.72~36
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dc51161bf8064f63470ee718843a1b4fd75d0bb5;p=thirdparty%2Fkernel%2Fstable.git

ext4: avoid bh leak in retry path of ext4_expand_extra_isize_ea()

commit dcb9917ba041866686fe152850364826c4622a36 upstream.

Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index b1aa7fd4701d8..01f2cf3409fbc 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -1270,6 +1270,7 @@ retry:
 					new_extra_isize = s_min_extra_isize;
 					kfree(is); is = NULL;
 					kfree(bs); bs = NULL;
+					brelse(bh);
 					goto retry;
 				}
 				error = -1;