From: Phil Young <py@napatech.com>
Date: Fri, 13 Nov 2020 16:32:32 +0000 (-0500)
Subject: napatech: Add Deprecation Warning Message for HBA
X-Git-Tag: suricata-6.0.1~65
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dc5349a30cbd97938e21936b9ae0fda19470bea3;p=thirdparty%2Fsuricata.git

napatech: Add Deprecation Warning Message for HBA

Added a message that HBA will be deprecated in the future and removed
hba from default conf file.
---

diff --git a/src/runmode-napatech.c b/src/runmode-napatech.c
index d7a206e064..584e2d8e46 100644
--- a/src/runmode-napatech.c
+++ b/src/runmode-napatech.c
@@ -206,6 +206,9 @@ static void *NapatechConfigParser(const char *device)
      */
     if (ConfGetInt("napatech.hba", &conf->hba) == 0) {
         conf->hba = -1;
+    } else {
+        SCLogWarning(SC_WARN_COMPATIBILITY,
+                "Napatech Host Buffer Allocation (hba) will be deprecated in Suricata v7.0.");
     }
     return (void *) conf;
 }
diff --git a/suricata.yaml.in b/suricata.yaml.in
index e521ca5b79..3f1bae8f11 100644
--- a/suricata.yaml.in
+++ b/suricata.yaml.in
@@ -1762,12 +1762,6 @@ ipfw:
 
 
 napatech:
-    # The Host Buffer Allowance for all streams
-    # (-1 = OFF, 1 - 100 = percentage of the host buffer that can be held back)
-    # This may be enabled when sharing streams with another application.
-    # Otherwise, it should be turned off.
-    #hba: -1
-
     # When use_all_streams is set to "yes" the initialization code will query
     # the Napatech service for all configured streams and listen on all of them.
     # When set to "no" the streams config array will be used.