From: Štěpán Balážik <stepan@isc.org>
Date: Fri, 2 Jan 2026 18:05:33 +0000 (+0100)
Subject: Set default_aa on AsyncDnsServer to False by default
X-Git-Tag: v9.21.17~8^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dc58c7326499dab241450b8bb2c0f16df486a3e2;p=thirdparty%2Fbind9.git

Set default_aa on AsyncDnsServer to False by default

In 6e684d44 I mistakenly set the default for `default_aa` for
`AsyncDnsServer()` to `True` and then explicitly set it to True in
cases where all the `ResponseHandlers` said
`yield DnsResponseSend(..., authoritative=True)` as if the default was
`False`.

Also the rest of `AsyncDnsServer` code (namely `_prepare_responses`)
reads like `default_aa` is `False` by default.

This accidentally changed the behavior of servers which don't set the
`default_aa` and where AA is not set from the zone data
(e.g. `dispatch/ans3`).
---

diff --git a/bin/tests/system/isctest/asyncserver.py b/bin/tests/system/isctest/asyncserver.py
index d2b22d7c129..849dba300a7 100644
--- a/bin/tests/system/isctest/asyncserver.py
+++ b/bin/tests/system/isctest/asyncserver.py
@@ -822,7 +822,7 @@ class AsyncDnsServer(AsyncServer):
         self,
         /,
         default_rcode: dns.rcode.Rcode = dns.rcode.REFUSED,
-        default_aa: bool = True,
+        default_aa: bool = False,
         keyring: Union[
             Dict[dns.name.Name, dns.tsig.Key], None, _NoKeyringType
         ] = _NoKeyringType(),