From: Daniel P. Berrange <berrange@redhat.com>
Date: Wed, 19 Mar 2014 10:55:13 +0000 (+0000)
Subject: Remove bogus unref in virDBusMessageRead
X-Git-Tag: v1.2.3-rc1~86
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dc7f3ffc023e3decf6aca3a2cfba2d884f0413a4;p=thirdparty%2Flibvirt.git

Remove bogus unref in virDBusMessageRead

The virDBusMessageRead method should not have side-effects on
the message parameter passed in, so unref'ing it is wrong.
The caller should unref only when they decided they are done
with it.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---

diff --git a/src/util/virdbus.c b/src/util/virdbus.c
index ecfe9f6364..cbaf995813 100644
--- a/src/util/virdbus.c
+++ b/src/util/virdbus.c
@@ -1421,7 +1421,6 @@ int virDBusMessageRead(DBusMessage *msg,
     ret = virDBusMessageDecodeArgs(msg, types, args);
     va_end(args);
 
-    dbus_message_unref(msg);
     return ret;
 }