From: Noel Power <noel.power@suse.com>
Date: Thu, 23 May 2019 13:56:39 +0000 (+0000)
Subject: nsswitch: cppcheck: Fix ctunullpointer error
X-Git-Tag: ldb-2.0.5~496
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dc82866dd76c043f73a93cde061af730cc010695;p=thirdparty%2Fsamba.git

nsswitch: cppcheck: Fix ctunullpointer error

Fixes

nsswitch/pam_winbind.c:1379: error: ctunullpointer: Null pointer dereference: info <--[cppcheck]

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/nsswitch/pam_winbind.c b/nsswitch/pam_winbind.c
index 0ba1955f007..7841377fdd6 100644
--- a/nsswitch/pam_winbind.c
+++ b/nsswitch/pam_winbind.c
@@ -1375,14 +1375,16 @@ static void _pam_set_data_string(struct pwb_context *ctx,
 static void _pam_set_data_info3(struct pwb_context *ctx,
 				const struct wbcAuthUserInfo *info)
 {
-	_pam_set_data_string(ctx, PAM_WINBIND_HOMEDIR,
+	if (info != NULL) {
+		_pam_set_data_string(ctx, PAM_WINBIND_HOMEDIR,
 			     info->home_directory);
-	_pam_set_data_string(ctx, PAM_WINBIND_LOGONSCRIPT,
+		_pam_set_data_string(ctx, PAM_WINBIND_LOGONSCRIPT,
 			     info->logon_script);
-	_pam_set_data_string(ctx, PAM_WINBIND_LOGONSERVER,
+		_pam_set_data_string(ctx, PAM_WINBIND_LOGONSERVER,
 			     info->logon_server);
-	_pam_set_data_string(ctx, PAM_WINBIND_PROFILEPATH,
+		_pam_set_data_string(ctx, PAM_WINBIND_PROFILEPATH,
 			     info->profile_path);
+	}
 }
 
 /**