From: Julian Seward <jseward@acm.org>
Date: Thu, 24 May 2012 06:17:14 +0000 (+0000)
Subject: Fix incorrect uses of disAMode in some SSE4 instructions that have an
X-Git-Tag: svn/VALGRIND_3_8_1^2~131
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dc8ef39dd37bf2abfc1dafef49bda679782388ce;p=thirdparty%2Fvalgrind.git

Fix incorrect uses of disAMode in some SSE4 instructions that have an
immediate byte as a subopcode.  Fixes #294260.  (Patrick J. LoPresti,
lopresti@gmail.com)



git-svn-id: svn://svn.valgrind.org/vex/trunk@2347
---

diff --git a/VEX/priv/guest_amd64_toIR.c b/VEX/priv/guest_amd64_toIR.c
index 80474a46de..ce9f93c44f 100644
--- a/VEX/priv/guest_amd64_toIR.c
+++ b/VEX/priv/guest_amd64_toIR.c
@@ -15595,7 +15595,7 @@ static Long dis_PCMPxSTRx ( VexAbiInfo* vbi, Prefix pfx,
    } else {
       regNoL = 16; /* use XMM16 as an intermediary */
       regNoR = gregOfRexRM(pfx, modrm);
-      addr = disAMode( &alen, vbi, pfx, delta, dis_buf, 0 );
+      addr = disAMode( &alen, vbi, pfx, delta, dis_buf, 1 );
       /* No alignment check; I guess that makes sense, given that
          these insns are for dealing with C style strings. */
       stmt( IRStmt_Put( OFFB_YMM16, loadLE(Ity_V128, mkexpr(addr)) ));
@@ -15751,7 +15751,7 @@ Long dis_ESC_0F3A__SSE4 ( Bool* decode_OK,
                  imm, nameXMMReg( eregOfRexRM(pfx, modrm) ),
                       nameXMMReg( gregOfRexRM(pfx, modrm) ) );
          } else {
-            addr = disAMode( &alen, vbi, pfx, delta, dis_buf, 0 );
+            addr = disAMode( &alen, vbi, pfx, delta, dis_buf, 1 );
             gen_SEGV_if_not_16_aligned(addr);
             assign( src0, loadLE(Ity_F32,
                                  binop(Iop_Add64, mkexpr(addr), mkU64(0) )));
@@ -15813,7 +15813,7 @@ Long dis_ESC_0F3A__SSE4 ( Bool* decode_OK,
                  imm, nameXMMReg( eregOfRexRM(pfx, modrm) ),
                       nameXMMReg( gregOfRexRM(pfx, modrm) ) );
          } else {
-            addr = disAMode( &alen, vbi, pfx, delta, dis_buf, 0 );
+            addr = disAMode( &alen, vbi, pfx, delta, dis_buf, 1 );
             gen_SEGV_if_not_16_aligned(addr);
             assign( src0, loadLE(Ity_F64,
                                  binop(Iop_Add64, mkexpr(addr), mkU64(0) )));
@@ -15868,7 +15868,7 @@ Long dis_ESC_0F3A__SSE4 ( Bool* decode_OK,
                  imm, nameXMMReg( eregOfRexRM(pfx, modrm) ),
                       nameXMMReg( gregOfRexRM(pfx, modrm) ) );
          } else {
-            addr = disAMode( &alen, vbi, pfx, delta, dis_buf, 0 );
+            addr = disAMode( &alen, vbi, pfx, delta, dis_buf, 1 );
             assign( src, loadLE( isD ? Ity_F64 : Ity_F32, mkexpr(addr) ));
             imm = getUChar(delta+alen);
             if (imm & ~15) goto decode_failure;
@@ -16811,7 +16811,7 @@ Long dis_ESC_0F3A__SSE4 ( Bool* decode_OK,
          } else {
             regNoL = 16; /* use XMM16 as an intermediary */
             regNoR = gregOfRexRM(pfx, modrm);
-            addr = disAMode( &alen, vbi, pfx, delta, dis_buf, 0 );
+            addr = disAMode( &alen, vbi, pfx, delta, dis_buf, 1 );
             /* alignment check ???? . */
             stmt( IRStmt_Put( OFFB_YMM16, loadLE(Ity_V128, mkexpr(addr)) ));
             imm = getUChar(delta+alen);