From: Volker Lendecke <vl@samba.org>
Date: Wed, 7 Jan 2026 11:56:28 +0000 (+0100)
Subject: loadparm: Simplify canonicalize_servicename()
X-Git-Tag: tdb-1.4.15~31
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dca79456db3b759348ca702b0caadd3f6bbe6e65;p=thirdparty%2Fsamba.git

loadparm: Simplify canonicalize_servicename()

We have strlower_talloc()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>
---

diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
index 410cb3ea937..2a958057e66 100644
--- a/source3/param/loadparm.c
+++ b/source3/param/loadparm.c
@@ -1598,17 +1598,12 @@ char *canonicalize_servicename(TALLOC_CTX *ctx, const char *src)
 	char *result;
 
 	if ( !src ) {
-		DEBUG(0,("canonicalize_servicename: NULL source name!\n"));
+		DBG_ERR("NULL source name!\n");
 		return NULL;
 	}
 
-	result = talloc_strdup(ctx, src);
+	result = strlower_talloc(ctx, src);
 	SMB_ASSERT(result != NULL);
-
-	if (!strlower_m(result)) {
-		TALLOC_FREE(result);
-		return NULL;
-	}
 	return result;
 }