From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 23 Jul 2025 15:10:07 +0000 (+0200)
Subject: more "shut up compiler"
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dcc10592c02196fbb20b1f1ac9a0fc13bda1594d;p=thirdparty%2Ffreeradius-server.git

more "shut up compiler"

clang scan passes, but the normal compiler complains
---

diff --git a/src/modules/rlm_dpsk/rlm_dpsk.c b/src/modules/rlm_dpsk/rlm_dpsk.c
index 96a005953a..29f3d39a6f 100644
--- a/src/modules/rlm_dpsk/rlm_dpsk.c
+++ b/src/modules/rlm_dpsk/rlm_dpsk.c
@@ -301,7 +301,7 @@ static rlm_rcode_t CC_HINT(nonnull) mod_authenticate(void *instance, REQUEST *re
 	eapol_attr_t const *eapol;
 	eapol_attr_t *zeroed;
 	FILE *fp = NULL;
-	char const *filename;
+	char const *filename = inst->filename;
 	char const *psk_identity = NULL, *psk = NULL;
 	uint8_t *p;
 	uint8_t const *snonce, *ap_mac;
@@ -523,15 +523,15 @@ stage2:
 		char token_mac[256];
 		char buffer[1024];
 
-		if (!inst->dynamic) {
-			filename = inst->filename;
-		} else {
+		if (inst->dynamic) {
 			if (radius_xlat(filename_buffer, sizeof(filename_buffer),
 					request, inst->filename, NULL, NULL) < 0) {
 				return RLM_MODULE_FAIL;
 			}
 
 			filename = filename_buffer;
+		} else {
+			fr_assert(filename == inst->filename);
 		}
 
 		RDEBUG3("Looking for PSK in file %s", filename);