From: Russell Bryant <russell@russellbryant.com>
Date: Mon, 22 Jun 2009 16:00:00 +0000 (+0000)
Subject: Make Polycom subscription type override check more explicit.
X-Git-Tag: 1.4.26-rc4~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dcfd8d7c7c7676c160684f8ec27fd39ca19c9301;p=thirdparty%2Fasterisk.git

Make Polycom subscription type override check more explicit.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@202414 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index cb65b2c665..a1e6279319 100644
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -15821,16 +15821,20 @@ static int handle_request_subscribe(struct sip_pvt *p, struct sip_request *req,
 		make_our_tag(p->tag, sizeof(p->tag));
 
 	if (!strcmp(event, "presence") || !strcmp(event, "dialog")) { /* Presence, RFC 3842 */
+		unsigned int pidf_xml;
+
 		if (authpeer)	/* No need for authpeer here */
 			ASTOBJ_UNREF(authpeer, sip_destroy_peer);
 
 		/* Header from Xten Eye-beam Accept: multipart/related, application/rlmi+xml, application/pidf+xml, application/xpidf+xml */
-		/* Polycom phones only handle xpidf+xml, even if they say they can
-		   handle pidf+xml as well
-		*/
-		if (strstr(p->useragent, "Polycom")) {
+
+		pidf_xml = strstr(accept, "application/pidf+xml") ? 1 : 0;
+
+		/* Older versions of Polycom firmware will claim pidf+xml, but really
+		 * they only support xpidf+xml. */
+		if (pidf_xml && strstr(p->useragent, "Polycom")) {
 			p->subscribed = XPIDF_XML;
-		} else if (strstr(accept, "application/pidf+xml")) {
+		} else if (pidf_xml) {
 			p->subscribed = PIDF_XML;         /* RFC 3863 format */
 		} else if (strstr(accept, "application/dialog-info+xml")) {
 			p->subscribed = DIALOG_INFO_XML;