From: Eric Blake <eblake@redhat.com>
Date: Mon, 4 Jul 2011 02:26:05 +0000 (+0800)
Subject: rpc: silence coverity warning
X-Git-Tag: v0.9.3~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dd0c42abd475fd580a3b149a3d7154a6443a6662;p=thirdparty%2Flibvirt.git

rpc: silence coverity warning

Coverity noted that 4 out of 5 calls to virNetClientStreamRaiseError
checked the return value.  This case expects a particular value, so
warn if our expectations went wrong due to some bug elsewhere.

* src/rpc/virnetclient.c (virNetClientCallDispatchStream): Warn on
  unexpected scenario.
---

diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c
index b551b99a00..615de6c2c8 100644
--- a/src/rpc/virnetclient.c
+++ b/src/rpc/virnetclient.c
@@ -602,7 +602,8 @@ static int virNetClientCallDispatchStream(virNetClientPtr client)
         if (thecall && thecall->expectReply) {
             VIR_DEBUG("Got a synchronous error");
             /* Raise error now, so that this call will see it immediately */
-            virNetClientStreamRaiseError(st);
+            if (!virNetClientStreamRaiseError(st))
+                VIR_DEBUG("unable to raise synchronous error");
             thecall->mode = VIR_NET_CLIENT_MODE_COMPLETE;
         }
         return 0;