From: Thomas Markwalder <tmark@isc.org>
Date: Tue, 29 Jan 2019 12:49:15 +0000 (-0500)
Subject: [#101,!202] Addressed review comments.
X-Git-Tag: 429-Updated-StampedValue-to-support-reals_base~33^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dd19826e7fb577cb400888b49741168d616eb6f4;p=thirdparty%2Fkea.git

[#101,!202] Addressed review comments.
---

diff --git a/src/bin/dhcp4/tests/config_backend_unittest.cc b/src/bin/dhcp4/tests/config_backend_unittest.cc
index 2e7f674aae..c6a3637d56 100644
--- a/src/bin/dhcp4/tests/config_backend_unittest.cc
+++ b/src/bin/dhcp4/tests/config_backend_unittest.cc
@@ -74,7 +74,7 @@ protected:
                         }
                     }
 
-                    // Apparently we're looking for on that does not prexist.
+                    // Apparently we're looking for one that does not prexist.
                     return (TestConfigBackendDHCPv4Ptr(new TestConfigBackendDHCPv4(params)));
                 });
     }
@@ -451,6 +451,7 @@ TEST_F(Dhcp4CBTest, DISABLED_mergeOptions) {
 
 // This test verifies that externally configured shared-networks are
 // merged correctly into staging configuration.
+// @todo enable test when SrvConfig can merge shared networks.
 TEST_F(Dhcp4CBTest, DISABLED_mergeSharedNetworks) {
     string base_config =
         "{ \n"
diff --git a/src/lib/cc/tests/stamped_value_unittest.cc b/src/lib/cc/tests/stamped_value_unittest.cc
index ad2581dcba..869ba41310 100644
--- a/src/lib/cc/tests/stamped_value_unittest.cc
+++ b/src/lib/cc/tests/stamped_value_unittest.cc
@@ -88,6 +88,14 @@ TEST(StampedValueTest, toElement) {
     ASSERT_THROW(value->toElement(Element::integer), BadValue);
     ASSERT_THROW(value->toElement(Element::real), BadValue);
 
+    // Make sure only lower case "true" and "false" works for Booleans.
+    ASSERT_NO_THROW(value.reset(new StampedValue("foo", "TRUE")));
+    ASSERT_THROW(value->toElement(Element::boolean), BadValue);
+    ASSERT_NO_THROW(value.reset(new StampedValue("foo", "FALSE")));
+    ASSERT_THROW(value->toElement(Element::boolean), BadValue);
+    ASSERT_NO_THROW(value.reset(new StampedValue("foo","nonsens")));
+    ASSERT_THROW(value->toElement(Element::boolean), BadValue);
+
     // Make sure we can create a DoubleElement.
     ASSERT_NO_THROW(value.reset(new StampedValue("foo", "45.0")));
     ASSERT_NO_THROW(elem = value->toElement(Element::real));