From: JINMEI Tatuya <jinmei@isc.org>
Date: Fri, 8 Feb 2013 16:21:01 +0000 (-0800)
Subject: [2661] protect the output of 'python-config | sed' with [], with more comments.
X-Git-Tag: bind10-1.0.0-rc-release~20^2~1^2~2^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dd447189c8e307c305415a34894c48972cea5a2c;p=thirdparty%2Fkea.git

[2661] protect the output of 'python-config | sed' with [], with more comments.

without [] the output it seems possible that the output is empty for some
environments.  also clarified that we can ignore the cases where -L isn't
contained at all.
---

diff --git a/configure.ac b/configure.ac
index fad1e20823..df0fd695d5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -298,12 +298,16 @@ AC_SUBST(COMMON_PYTHON_PATH)
 if test -x ${PYTHON}-config; then
 	PYTHON_INCLUDES=`${PYTHON}-config --includes`
 
-	# make a copy of python-config --ldflags, removing any spaces and tabs
+	# Add any '-L..." flags to PYTHON_LDFLAGS.  We first make a copy of
+	# python-config --ldflags, removing any spaces and tabs
 	# between "-L" and its argument (some instances of python-config
-	# insert a space, which would confuse the code below)
-	python_config_ldflags=`${PYTHON}-config --ldflags | sed -ne 's/\([ \t]*-L\)[ ]*\([^ \t]*[ \t]*\)/\1\2/pg'`
+	# insert a space, which would confuse the code below).
+	# Notes: if -L isn't contained at all we can simply skip this process,
+	# so we only go through the flag if it's contained; also, protecting
+	# the output with [] seems necessary for environment to avoid getting
+	# an empty output accidentally.
+	python_config_ldflags=[`${PYTHON}-config --ldflags | sed -ne 's/\([ \t]*-L\)[ ]*\([^ \t]*[ \t]*\)/\1\2/pg'`]
 	for flag in $python_config_ldflags; do
-		# add any '-L..." flags to PYTHON_LDFLAGS
 		flag=`echo $flag | sed -ne 's/^\(\-L.*\)$/\1/p'`
 		if test "X${flag}" != X; then
 			PYTHON_LDFLAGS="$PYTHON_LDFLAGS ${flag}"