From: Jim Meyering Date: Sun, 7 Nov 2010 13:23:32 +0000 (+0100) Subject: tests: don't disqualify FreeBSD 8.1's /bin/sh just yet, X-Git-Tag: v8.7~11 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dd45755406861fc192284d7e2b28f3c33e0433d3;p=thirdparty%2Fcoreutils.git tests: don't disqualify FreeBSD 8.1's /bin/sh just yet, because dash-0.5.6-2.fc14.x86_64 would also be disqualified. This reverts part of yesterday's commit 6c058b2d, "tests: avoid failure due to bug in FreeBSD 8.1's /bin/sh". Note that the offending aspect of those shells is not officially a bug, since "local" is not specified by POSIX. However, it is very unintuitive that prepending "local" to an existing, standards-compliant assignment would evoke such a fundamental change in semantics. * tests/init.sh: Remove snippet requiring sane "local" support. Upstream dash bug report: http://thread.gmane.org/gmane.comp.shells.dash/419 --- diff --git a/tests/init.sh b/tests/init.sh index 0193cbec1f..a57de77a2f 100644 --- a/tests/init.sh +++ b/tests/init.sh @@ -93,9 +93,6 @@ else fi # We require $(...) support unconditionally. -# We also require "local" support. The local-vs-IFS test is required to -# eliminate FreeBSD 8.1's /bin/sh, which would otherwise pass these tests -# and provoke opaque test failures in coreutils. # We require a few additional shell features only when $EXEEXT is nonempty, # in order to support automatic $EXEEXT emulation: # - hyphen-containing alias names @@ -118,7 +115,6 @@ fi # ? - not ok gl_shell_test_script_=' test $(echo y) = y || exit 1 -gl_local_test_(){ local s=$IFS; test -n "$s"; }; gl_local_test_ || exit 1 score_=10 if test "$VERBOSE" = yes; then test -n "$( (exec 3>&1; set -x; P=1 true 2>&3) 2> /dev/null)" && score_=9