From: Jürg Billeter Date: Fri, 14 Nov 2008 17:41:23 +0000 (+0000) Subject: Report unused fields, methods, and local variables X-Git-Tag: VALA_0_5_2~95 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dd76fd18d25cfdaef8aa07b761f153fab6330f3b;p=thirdparty%2Fvala.git Report unused fields, methods, and local variables 2008-11-14 Jürg Billeter * vala/valacfgbuilder.vala: * vala/valamemberaccess.vala: * vala/valamethod.vala: * vala/valasymbol.vala: * gobject/valaccodemethodmodule.vala: Report unused fields, methods, and local variables * vala/valacodecontext.vala: * vala/valadynamicproperty.vala: * vala/valaenum.vala: * vala/valagenieparser.vala: * vala/valainterfacewriter.vala: * vala/valaparser.vala: * vala/valastruct.vala: * vala/valaunresolvedtype.vala: * gobject/valaccodearraymodule.vala: * gobject/valaccodeassignmentmodule.vala: * gobject/valaccodebasemodule.vala: * gobject/valaccodeinvocationexpressionmodule.vala: * gobject/valaccodememberaccessmodule.vala: * gobject/valadbusservermodule.vala: * gobject/valagobjectmodule.vala: * vapigen/valagirparser.vala: * vapigen/valamarkupreader.vala: Remove unused symbols svn path=/trunk/; revision=2016 --- diff --git a/ChangeLog b/ChangeLog index 905f8845a..6e272da77 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,33 @@ +2008-11-14 Jürg Billeter + + * vala/valacfgbuilder.vala: + * vala/valamemberaccess.vala: + * vala/valamethod.vala: + * vala/valasymbol.vala: + * gobject/valaccodemethodmodule.vala: + + Report unused fields, methods, and local variables + + * vala/valacodecontext.vala: + * vala/valadynamicproperty.vala: + * vala/valaenum.vala: + * vala/valagenieparser.vala: + * vala/valainterfacewriter.vala: + * vala/valaparser.vala: + * vala/valastruct.vala: + * vala/valaunresolvedtype.vala: + * gobject/valaccodearraymodule.vala: + * gobject/valaccodeassignmentmodule.vala: + * gobject/valaccodebasemodule.vala: + * gobject/valaccodeinvocationexpressionmodule.vala: + * gobject/valaccodememberaccessmodule.vala: + * gobject/valadbusservermodule.vala: + * gobject/valagobjectmodule.vala: + * vapigen/valagirparser.vala: + * vapigen/valamarkupreader.vala: + + Remove unused symbols + 2008-11-14 Jürg Billeter * tests/Makefile.am: diff --git a/gobject/valaccodearraymodule.vala b/gobject/valaccodearraymodule.vala index 55e5fa6bd..8754a657a 100644 --- a/gobject/valaccodearraymodule.vala +++ b/gobject/valaccodearraymodule.vala @@ -178,8 +178,6 @@ public class Vala.CCodeArrayModule : CCodeInvocationExpressionModule { } var length_cname = get_array_length_cname (field.name, dim); - var instance_expression_type = get_data_type_for_symbol (base_type); - var instance_target_type = get_data_type_for_symbol ((TypeSymbol) field.parent_symbol); CCodeExpression typed_inst = (CCodeExpression) get_ccodenode (ma.inner); CCodeExpression inst; diff --git a/gobject/valaccodeassignmentmodule.vala b/gobject/valaccodeassignmentmodule.vala index c1e6a3f58..a1262b28d 100644 --- a/gobject/valaccodeassignmentmodule.vala +++ b/gobject/valaccodeassignmentmodule.vala @@ -167,7 +167,6 @@ public class Vala.CCodeAssignmentModule : CCodeMemberAccessModule { ccomma.append_expression (new CCodeAssignment (lhs_array_len, rhs_array_len)); } } else if (instance_delegate) { - var delegate_type = (DelegateType) assignment.left.value_type; var lhs_delegate_target = get_delegate_target_cexpression (assignment.left); var rhs_delegate_target = get_delegate_target_cexpression (assignment.right); ccomma.append_expression (new CCodeAssignment (lhs_delegate_target, rhs_delegate_target)); diff --git a/gobject/valaccodebasemodule.vala b/gobject/valaccodebasemodule.vala index a4af096de..f95fc7d8c 100644 --- a/gobject/valaccodebasemodule.vala +++ b/gobject/valaccodebasemodule.vala @@ -1592,8 +1592,6 @@ public class Vala.CCodeBaseModule : CCodeModule { var function = new CCodeFunction (destroy_func, "void"); function.modifiers = CCodeModifiers.STATIC; - var cparam_map = new HashMap (direct_hash, direct_equal); - function.add_parameter (new CCodeFormalParameter ("self", list_type.get_cname ())); // definition diff --git a/gobject/valaccodeinvocationexpressionmodule.vala b/gobject/valaccodeinvocationexpressionmodule.vala index 0f620bd9b..fb993e1ff 100644 --- a/gobject/valaccodeinvocationexpressionmodule.vala +++ b/gobject/valaccodeinvocationexpressionmodule.vala @@ -169,7 +169,6 @@ public class Vala.CCodeInvocationExpressionModule : CCodeAssignmentModule { Iterator params_it = params.iterator (); foreach (Expression arg in expr.get_argument_list ()) { CCodeExpression cexpr = (CCodeExpression) arg.ccodenode; - Gee.List extra_args = new ArrayList (); if (params_it.next ()) { var param = params_it.get (); ellipsis = param.ellipsis; diff --git a/gobject/valaccodememberaccessmodule.vala b/gobject/valaccodememberaccessmodule.vala index bc77bb1a0..cb22da5e4 100644 --- a/gobject/valaccodememberaccessmodule.vala +++ b/gobject/valaccodememberaccessmodule.vala @@ -89,7 +89,6 @@ public class Vala.CCodeMemberAccessModule : CCodeControlFlowModule { } else if (expr.symbol_reference is Field) { var f = (Field) expr.symbol_reference; if (f.binding == MemberBinding.INSTANCE) { - var instance_expression_type = base_type; var instance_target_type = get_data_type_for_symbol ((TypeSymbol) f.parent_symbol); var cl = instance_target_type.data_type as Class; diff --git a/gobject/valaccodemethodmodule.vala b/gobject/valaccodemethodmodule.vala index a201ef974..2394f9ced 100644 --- a/gobject/valaccodemethodmodule.vala +++ b/gobject/valaccodemethodmodule.vala @@ -555,8 +555,6 @@ public class Vala.CCodeMethodModule : CCodeStructModule { var vfunc = new CCodeFunction (m.get_cname (), creturn_type.get_cname ()); vfunc.line = function.line; - ReferenceType this_type = new ObjectType ((Class) m.parent_symbol); - cparam_map = new HashMap (direct_hash, direct_equal); var carg_map = new HashMap (direct_hash, direct_equal); @@ -609,9 +607,7 @@ public class Vala.CCodeMethodModule : CCodeStructModule { } } - bool return_value = true; - bool args_parameter = true; - if (is_possible_entry_point (m, ref return_value, ref args_parameter)) { + if (m.entry_point) { // m is possible entry point, add appropriate startup code var cmain = new CCodeFunction ("main", "int"); cmain.line = function.line; @@ -631,15 +627,11 @@ public class Vala.CCodeMethodModule : CCodeStructModule { main_block.add_statement (type_init_call); var main_call = new CCodeFunctionCall (new CCodeIdentifier (function.name)); - if (args_parameter) { + if (m.get_parameters ().size == 1) { main_call.add_argument (new CCodeIdentifier ("argv")); main_call.add_argument (new CCodeIdentifier ("argc")); } - if (return_value) { - var main_stmt = new CCodeReturnStatement (main_call); - main_stmt.line = cmain.line; - main_block.add_statement (main_stmt); - } else { + if (m.return_type is VoidType) { // method returns void, always use 0 as exit code var main_stmt = new CCodeExpressionStatement (main_call); main_stmt.line = cmain.line; @@ -647,6 +639,10 @@ public class Vala.CCodeMethodModule : CCodeStructModule { var ret_stmt = new CCodeReturnStatement (new CCodeConstant ("0")); ret_stmt.line = cmain.line; main_block.add_statement (ret_stmt); + } else { + var main_stmt = new CCodeReturnStatement (main_call); + main_stmt.line = cmain.line; + main_block.add_statement (main_stmt); } cmain.block = main_block; source_type_member_definition.append (cmain); @@ -833,62 +829,6 @@ public class Vala.CCodeMethodModule : CCodeStructModule { return null; } - private bool is_possible_entry_point (Method m, ref bool return_value, ref bool args_parameter) { - if (m.name == null || m.name != "main") { - // method must be called "main" - return false; - } - - if (m.binding == MemberBinding.INSTANCE) { - // method must be static - return false; - } - - if (m.return_type.data_type == null) { - return_value = false; - } else if (m.return_type.data_type == int_type.data_type) { - return_value = true; - } else { - // return type must be void or int - return false; - } - - var params = m.get_parameters (); - if (params.size == 0) { - // method may have no parameters - args_parameter = false; - return true; - } - - if (params.size > 1) { - // method must not have more than one parameter - return false; - } - - Iterator params_it = params.iterator (); - params_it.next (); - var param = params_it.get (); - - if (param.direction == ParameterDirection.OUT) { - // parameter must not be an out parameter - return false; - } - - if (!(param.parameter_type is ArrayType)) { - // parameter must be an array - return false; - } - - var array_type = (ArrayType) param.parameter_type; - if (array_type.element_type.data_type != string_type.data_type) { - // parameter must be an array of strings - return false; - } - - args_parameter = true; - return true; - } - private void add_object_creation (CCodeBlock b, bool has_params) { var cl = (Class) current_type_symbol; diff --git a/gobject/valadbusservermodule.vala b/gobject/valadbusservermodule.vala index 67c16e2e9..1c5b2265a 100644 --- a/gobject/valadbusservermodule.vala +++ b/gobject/valadbusservermodule.vala @@ -365,7 +365,6 @@ public class Vala.DBusServerModule : DBusClientModule { } else if (param.parameter_type.get_type_signature ().has_prefix ("a{")) { // hash table output parameter var type_args = param.parameter_type.get_type_arguments (); - var key_type = type_args.get (0); var value_type = type_args.get (1); if (value_type.get_type_signature ().has_prefix ("(")) { // values are structs @@ -393,7 +392,6 @@ public class Vala.DBusServerModule : DBusClientModule { } else if (m.return_type.get_type_signature ().has_prefix ("a{")) { // hash table output parameter var type_args = m.return_type.get_type_arguments (); - var key_type = type_args.get (0); var value_type = type_args.get (1); if (value_type.get_type_signature ().has_prefix ("(")) { // values are structs @@ -436,7 +434,6 @@ public class Vala.DBusServerModule : DBusClientModule { } else if (param.parameter_type.get_type_signature ().has_prefix ("a{")) { // hash table output parameter var type_args = param.parameter_type.get_type_arguments (); - var key_type = type_args.get (0); var value_type = type_args.get (1); if (value_type.get_type_signature ().has_prefix ("(")) { // values are structs @@ -462,7 +459,6 @@ public class Vala.DBusServerModule : DBusClientModule { } else if (m.return_type.get_type_signature ().has_prefix ("a{")) { // hash table return value var type_args = m.return_type.get_type_arguments (); - var key_type = type_args.get (0); var value_type = type_args.get (1); if (value_type.get_type_signature ().has_prefix ("(")) { // values are structs @@ -524,7 +520,6 @@ public class Vala.DBusServerModule : DBusClientModule { } else if (param.parameter_type.get_type_signature ().has_prefix ("a{")) { // hash table output parameter var type_args = param.parameter_type.get_type_arguments (); - var key_type = type_args.get (0); var value_type = type_args.get (1); if (value_type.get_type_signature ().has_prefix ("(")) { // values are structs @@ -552,7 +547,6 @@ public class Vala.DBusServerModule : DBusClientModule { } else if (m.return_type.get_type_signature ().has_prefix ("a{")) { // hash table output parameter var type_args = m.return_type.get_type_arguments (); - var key_type = type_args.get (0); var value_type = type_args.get (1); if (value_type.get_type_signature ().has_prefix ("(")) { // values are structs @@ -583,7 +577,6 @@ public class Vala.DBusServerModule : DBusClientModule { } else if (param.parameter_type.get_type_signature ().has_prefix ("a{")) { // hash table output parameter var type_args = param.parameter_type.get_type_arguments (); - var key_type = type_args.get (0); var value_type = type_args.get (1); if (value_type.get_type_signature ().has_prefix ("(")) { // values are structs @@ -635,7 +628,6 @@ public class Vala.DBusServerModule : DBusClientModule { } else if (m.return_type.get_type_signature ().has_prefix ("a{")) { // hash table output parameter var type_args = m.return_type.get_type_arguments (); - var key_type = type_args.get (0); var value_type = type_args.get (1); if (value_type.get_type_signature ().has_prefix ("(")) { // values are structs diff --git a/gobject/valagobjectmodule.vala b/gobject/valagobjectmodule.vala index dee9668ca..68f97d19c 100644 --- a/gobject/valagobjectmodule.vala +++ b/gobject/valagobjectmodule.vala @@ -306,9 +306,11 @@ public class Vala.GObjectModule : GTypeModule { source_type_member_definition.append (function); } + current_symbol = old_symbol; current_type_symbol = old_type_symbol; current_class = old_class; instance_struct = old_instance_struct; + param_spec_struct = old_param_spec_struct; type_struct = old_type_struct; instance_priv_struct = old_instance_priv_struct; prop_enum = old_prop_enum; diff --git a/vala/valacfgbuilder.vala b/vala/valacfgbuilder.vala index 64a138f31..fe65091e7 100644 --- a/vala/valacfgbuilder.vala +++ b/vala/valacfgbuilder.vala @@ -118,7 +118,21 @@ public class Vala.CFGBuilder : CodeVisitor { ed.accept_children (this); } + public override void visit_field (Field f) { + if (f.access != SymbolAccessibility.PUBLIC + && f.access != SymbolAccessibility.PROTECTED + && !f.used) { + Report.warning (f.source_reference, "field `%s' never used".printf (f.get_full_name ())); + } + } + public override void visit_method (Method m) { + if (m.access != SymbolAccessibility.PUBLIC + && m.access != SymbolAccessibility.PROTECTED + && !m.used && !m.entry_point) { + Report.warning (m.source_reference, "method `%s' never used".printf (m.get_full_name ())); + } + if (m.body == null) { return; } @@ -189,6 +203,10 @@ public class Vala.CFGBuilder : CodeVisitor { return; } + if (!stmt.declaration.used) { + Report.warning (stmt.declaration.source_reference, "local variable `%s' declared but never used".printf (stmt.declaration.name)); + } + current_block.add_node (stmt); var local = stmt.declaration as LocalVariable; diff --git a/vala/valacodecontext.vala b/vala/valacodecontext.vala index 67252c631..1654d1c08 100644 --- a/vala/valacodecontext.vala +++ b/vala/valacodecontext.vala @@ -345,7 +345,7 @@ public class Vala.CodeContext { continue; } - if (cycle_file.cycle != null) { + if (ref_cycle_file_cycle != null) { /* file already in a cycle */ if (cycle_file.cycle == cycle) { diff --git a/vala/valadynamicproperty.vala b/vala/valadynamicproperty.vala index cc092c26b..c7ee1253a 100644 --- a/vala/valadynamicproperty.vala +++ b/vala/valadynamicproperty.vala @@ -29,8 +29,6 @@ using Gee; public class Vala.DynamicProperty : Property { public DataType dynamic_type { get; set; } - private string cname; - public DynamicProperty (DataType dynamic_type, string name, SourceReference? source_reference = null) { base (name, null, null, null, source_reference); this.dynamic_type = dynamic_type; diff --git a/vala/valaenum.vala b/vala/valaenum.vala index d1da55e68..56eca2b2f 100644 --- a/vala/valaenum.vala +++ b/vala/valaenum.vala @@ -160,11 +160,7 @@ public class Vala.Enum : TypeSymbol { public override bool is_reference_type () { return false; } - - private void set_cname (string cname) { - this.cname = cname; - } - + /** * Returns the string to be prepended to the name of members of this * enum when used in C code. diff --git a/vala/valagenieparser.vala b/vala/valagenieparser.vala index 60595ceb8..d004710af 100644 --- a/vala/valagenieparser.vala +++ b/vala/valagenieparser.vala @@ -201,12 +201,6 @@ public class Vala.Genie.Parser : CodeVisitor { return new SourceReference (scanner.source_file, tokens[index].begin.line, tokens[index].begin.column, tokens[index].end.line, tokens[index].end.column); } - SourceReference get_last_src () { - int last_index = (index + BUFFER_SIZE - 1) % BUFFER_SIZE; - - return new SourceReference (scanner.source_file, tokens[last_index].begin.line, tokens[last_index].begin.column, tokens[last_index].end.line, tokens[last_index].end.column); - } - void rollback (SourceLocation location) { while (tokens[index].begin.pos != location.pos) { prev (); @@ -1684,7 +1678,6 @@ public class Vala.Genie.Parser : CodeVisitor { Block parse_block () throws ParseError { var begin = get_location (); - Gee.List list = new ArrayList (); expect (TokenType.INDENT); var block = new Block (get_src_com (begin)); parse_statements (block); @@ -1715,8 +1708,6 @@ public class Vala.Genie.Parser : CodeVisitor { } void parse_local_variable_declarations (Block block) throws ParseError { - var begin = get_location (); - if (accept (TokenType.VAR)) { /* support block vars */ if (accept (TokenType.EOL) && accept (TokenType.INDENT)) { @@ -2342,10 +2333,7 @@ public class Vala.Genie.Parser : CodeVisitor { } void parse_using_directives () throws ParseError { - var begin = get_location (); while (accept (TokenType.USES)) { - var begin = get_location (); - if (accept_block ()) { expect (TokenType.INDENT); @@ -2793,7 +2781,6 @@ public class Vala.Genie.Parser : CodeVisitor { while (current () != TokenType.DEDENT) { var accessor_begin = get_location (); parse_attributes (); - var accessor_access = SymbolAccessibility.PUBLIC; if (accept (TokenType.GET)) { if (prop.get_accessor != null) { throw new ParseError.SYNTAX (get_error ("property get accessor already defined")); @@ -3296,7 +3283,7 @@ public class Vala.Genie.Parser : CodeVisitor { expect (TokenType.CONSTRUCT); - var flags = parse_member_declaration_modifiers (); + parse_member_declaration_modifiers (); if (accept (TokenType.OPEN_PARENS)) { @@ -3480,27 +3467,5 @@ public class Vala.Genie.Parser : CodeVisitor { } while (accept (TokenType.DOT)); return expr; } - - bool is_declaration_keyword (TokenType type) { - switch (type) { - case TokenType.CLASS: - case TokenType.CONST: - case TokenType.DEF: - case TokenType.DELEGATE: - case TokenType.ENUM: - case TokenType.ERRORDOMAIN: - case TokenType.EVENT: - case TokenType.FINAL: - case TokenType.INIT: - case TokenType.INTERFACE: - case TokenType.NAMESPACE: - case TokenType.OVERRIDE: - case TokenType.PROP: - case TokenType.STRUCT: - return true; - default: - return false; - } - } } diff --git a/vala/valainterfacewriter.vala b/vala/valainterfacewriter.vala index 970f5dca4..f2cfcfe56 100644 --- a/vala/valainterfacewriter.vala +++ b/vala/valainterfacewriter.vala @@ -36,8 +36,6 @@ public class Vala.InterfaceWriter : CodeVisitor { /* at begin of line */ bool bol = true; - string current_cheader_filename; - Scope current_scope; /** diff --git a/vala/valamemberaccess.vala b/vala/valamemberaccess.vala index 7d5bacf42..6ced16f4c 100644 --- a/vala/valamemberaccess.vala +++ b/vala/valamemberaccess.vala @@ -444,6 +444,8 @@ public class Vala.MemberAccess : Expression { instance = true; } + member.used = true; + if (access == SymbolAccessibility.PRIVATE) { var target_type = member.parent_symbol; diff --git a/vala/valamethod.vala b/vala/valamethod.vala index a91412ac8..8dd2ccd24 100644 --- a/vala/valamethod.vala +++ b/vala/valamethod.vala @@ -145,7 +145,9 @@ public class Vala.Method : Member { return _base_interface_method; } } - + + public bool entry_point { get; private set; } + /** * Specifies the generated `this' parameter for instance methods. */ @@ -768,6 +770,62 @@ public class Vala.Method : Member { } } + if (is_possible_entry_point (analyzer)) { + entry_point = true; + } + return !error; } + + bool is_possible_entry_point (SemanticAnalyzer analyzer) { + if (name == null || name != "main") { + // method must be called "main" + return false; + } + + if (binding == MemberBinding.INSTANCE) { + // method must be static + return false; + } + + if (return_type is VoidType) { + } else if (return_type.data_type == analyzer.int_type.data_type) { + } else { + // return type must be void or int + return false; + } + + var params = get_parameters (); + if (params.size == 0) { + // method may have no parameters + return true; + } + + if (params.size > 1) { + // method must not have more than one parameter + return false; + } + + Iterator params_it = params.iterator (); + params_it.next (); + var param = params_it.get (); + + if (param.direction == ParameterDirection.OUT) { + // parameter must not be an out parameter + return false; + } + + if (!(param.parameter_type is ArrayType)) { + // parameter must be an array + return false; + } + + var array_type = (ArrayType) param.parameter_type; + if (array_type.element_type.data_type != analyzer.string_type.data_type) { + // parameter must be an array of strings + return false; + } + + return true; + } } diff --git a/vala/valaparser.vala b/vala/valaparser.vala index b49d39d55..9fce44012 100644 --- a/vala/valaparser.vala +++ b/vala/valaparser.vala @@ -1341,7 +1341,6 @@ public class Vala.Parser : CodeVisitor { Block parse_block () throws ParseError { var begin = get_location (); - Gee.List list = new ArrayList (); expect (TokenType.OPEN_BRACE); var block = new Block (get_src_com (begin)); parse_statements (block); @@ -1365,7 +1364,6 @@ public class Vala.Parser : CodeVisitor { } void parse_local_variable_declarations (Block block) throws ParseError { - var begin = get_location (); DataType variable_type; if (accept (TokenType.VAR)) { variable_type = null; @@ -1929,8 +1927,6 @@ public class Vala.Parser : CodeVisitor { void parse_using_directives () throws ParseError { while (accept (TokenType.USING)) { - var begin = get_location (); - do { var begin = get_location (); var sym = parse_symbol_name (); diff --git a/vala/valastruct.vala b/vala/valastruct.vala index 7efc9500e..daab55369 100644 --- a/vala/valastruct.vala +++ b/vala/valastruct.vala @@ -36,8 +36,6 @@ public class Vala.Struct : TypeSymbol { private string cname; private string const_cname; - private string dup_function; - private string free_function; private string type_id; private string lower_case_cprefix; private string lower_case_csuffix; @@ -222,10 +220,6 @@ public class Vala.Struct : TypeSymbol { return "%s%s".printf (parent_symbol.get_cprefix (), name); } - private void set_cname (string cname) { - this.cname = cname; - } - private void set_const_cname (string cname) { this.const_cname = cname; } diff --git a/vala/valasymbol.vala b/vala/valasymbol.vala index b9ccd7e94..ac0ec44c5 100644 --- a/vala/valasymbol.vala +++ b/vala/valasymbol.vala @@ -68,6 +68,11 @@ public abstract class Vala.Symbol : CodeNode { */ public bool active { get; set; default = true; } + /** + * Specifies whether this symbol has been accessed. + */ + public bool used { get; set; } + /** * Specifies the accessibility of this symbol. Public accessibility * doesn't limit access. Default accessibility limits access to this diff --git a/vala/valaunresolvedtype.vala b/vala/valaunresolvedtype.vala index bde88516c..a651c47d4 100644 --- a/vala/valaunresolvedtype.vala +++ b/vala/valaunresolvedtype.vala @@ -56,8 +56,6 @@ public class Vala.UnresolvedType : DataType { * @return newly created type reference */ public static UnresolvedType? new_from_expression (Expression expr) { - string ns = null; - string type_name = null; if (expr is MemberAccess) { UnresolvedType type_ref = null; diff --git a/vapigen/valagirparser.vala b/vapigen/valagirparser.vala index 09571e249..a8b6fc20d 100644 --- a/vapigen/valagirparser.vala +++ b/vapigen/valagirparser.vala @@ -670,7 +670,7 @@ public class Vala.GirParser : CodeVisitor { string name = reader.get_attribute ("name"); next (); - var return_type = parse_return_value (); + parse_return_value (); var m = new CreationMethod (null, name, get_current_src ()); m.access = SymbolAccessibility.PUBLIC; diff --git a/vapigen/valamarkupreader.vala b/vapigen/valamarkupreader.vala index 81b2b443c..3c308d04f 100644 --- a/vapigen/valamarkupreader.vala +++ b/vapigen/valamarkupreader.vala @@ -189,7 +189,7 @@ public class Vala.MarkupReader : Object { return read_token (out token_begin, out token_end); } type = MarkupTokenType.TEXT; - string text = ((string) text_begin).ndup (current - text_begin); + // string text = ((string) text_begin).ndup (current - text_begin); } column += (int) (current - begin);