From: Daniel Frey <d.frey@gmx.de>
Date: Sun, 17 Apr 2022 07:42:45 +0000 (+0200)
Subject: Simplify code
X-Git-Tag: auth-4.8.0-alpha0~18^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dd7ee0c74d6de14b90959cfbd9ebfb1c246226a5;p=thirdparty%2Fpdns.git

Simplify code

Removes a superfluous `if` and folds both branches which had identical behavior.
---

diff --git a/modules/bindbackend/bindbackend2.cc b/modules/bindbackend/bindbackend2.cc
index 43e2034999..a584f4137e 100644
--- a/modules/bindbackend/bindbackend2.cc
+++ b/modules/bindbackend/bindbackend2.cc
@@ -1206,17 +1206,9 @@ void Bind2Backend::lookup(const QType& qtype, const DNSName& qname, int zoneId,
   auto& hashedidx = boost::multi_index::get<UnorderedNameTag>(*d_handle.d_records);
   auto range = hashedidx.equal_range(d_handle.qname);
 
-  if (range.first == range.second) {
-    d_handle.d_list = false;
-    d_handle.d_iter = d_handle.d_end_iter = range.first;
-    return;
-  }
-  else {
-    d_handle.d_iter = range.first;
-    d_handle.d_end_iter = range.second;
-  }
-
   d_handle.d_list = false;
+  d_handle.d_iter = range.first;
+  d_handle.d_end_iter = range.second;
 }
 
 Bind2Backend::handle::handle()