From: Niels Möller <nisse@lysator.liu.se>
Date: Tue, 16 Feb 2016 07:20:58 +0000 (+0100)
Subject: Fix sexp-conv assertion failure, reported by Hanno Böck.
X-Git-Tag: nettle_3.3_release_20161001~64
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dd83950b0614ca4aec73da843bfb175c8278be9c;p=thirdparty%2Fnettle.git

Fix sexp-conv assertion failure, reported by Hanno Böck.
---

diff --git a/ChangeLog b/ChangeLog
index 8b430037..c9c522bf 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2016-02-16  Niels Möller  <nisse@lysator.liu.se>
 
+	* tools/input.c (sexp_get_string_length): Process advanced string
+	syntax only when in advanced mode. Fixes an assertion failure
+	reported by Hanno Böck, for input where advanced syntax is
+	improperly wrapped inside transport syntax.
+
 	* tools/parse.c (sexp_parse): Fail with an error message for
 	unexpected ']' characters. Fixes crash reported by Hanno Böck.
 	Also handle SEXP_DISPLAY (internal error) explicitly, without a
diff --git a/tools/input.c b/tools/input.c
index b8085a4e..18a9dff5 100644
--- a/tools/input.c
+++ b/tools/input.c
@@ -286,57 +286,56 @@ sexp_get_string_length(struct sexp_input *input, enum sexp_mode mode,
 	}
     }
 
-  switch(input->c)
-    {
-    case ':':
-      /* Verbatim */
-      for (; length; length--)
-	{
-	  sexp_next_char(input);
-	  sexp_push_char(input, string);
-	}
-      
-      break;
+  if (input->c == ':')
+    /* Verbatim */
+    for (; length; length--)
+      {
+	sexp_next_char(input);
+	sexp_push_char(input, string);
+      }
 
-    case '"':
-      if (mode != SEXP_ADVANCED)
-	die("Encountered quoted string in canonical mode.\n");
+  else if (mode != SEXP_ADVANCED)
+    die("Encountered advanced string in canonical mode.\n");
 
-      for (; length; length--)
-	if (sexp_get_quoted_char(input))
-	  sexp_push_char(input, string);
-	else
-	  die("Unexpected end of string.\n");
+  else
+    switch(input->c)
+      {
+      case '"':
+	for (; length; length--)
+	  if (sexp_get_quoted_char(input))
+	    sexp_push_char(input, string);
+	  else
+	    die("Unexpected end of string.\n");
       
-      if (sexp_get_quoted_char(input))
-	die("Quoted string longer than expected.\n");
+	if (sexp_get_quoted_char(input))
+	  die("Quoted string longer than expected.\n");
 
-      break;
+	break;
       
-    case '#':
-      sexp_input_start_coding(input, &nettle_base16, '#');
-      goto decode;
+      case '#':
+	sexp_input_start_coding(input, &nettle_base16, '#');
+	goto decode;
 
-    case '|':
-      sexp_input_start_coding(input, &nettle_base64, '|');
+      case '|':
+	sexp_input_start_coding(input, &nettle_base64, '|');
 
-    decode:
-      for (; length; length--)
-	{
-	  sexp_next_char(input);
-	  sexp_push_char(input, string);
-	}
-      sexp_get_char(input);
-      if (input->ctype != SEXP_END_CHAR)
-	die("Coded string too long.\n");
+      decode:
+	for (; length; length--)
+	  {
+	    sexp_next_char(input);
+	    sexp_push_char(input, string);
+	  }
+	sexp_get_char(input);
+	if (input->ctype != SEXP_END_CHAR)
+	  die("Coded string too long.\n");
 
-      sexp_input_end_coding(input);
+	sexp_input_end_coding(input);
       
-      break;
+	break;
       
-    default:
-      die("Invalid string.\n");
-    }
+      default:
+	die("Invalid string.\n");
+      }
 
   /* Skip the ending character. */
   sexp_get_char(input);