From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Fri, 26 May 2017 02:00:45 +0000 (-0400)
Subject: CID 1409872: Always call va_end
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dda66f3c8dac30f905bb2915f18b4f5f9ecb60d5;p=thirdparty%2Ffreeradius-server.git

CID 1409872: Always call va_end
---

diff --git a/src/lib/util/log.c b/src/lib/util/log.c
index a14f543c50f..ec4f7574a45 100644
--- a/src/lib/util/log.c
+++ b/src/lib/util/log.c
@@ -443,9 +443,10 @@ int fr_log_perror(fr_log_t const *log, log_type_t type, char const *msg, ...)
 
 		va_start(ap, msg);
 		tmp = talloc_vasprintf(NULL, msg, ap);
-		if (!tmp) return -1;
 		va_end(ap);
 
+		if (!tmp) return -1;
+
 		fr_log(log, type, "%s: %s", tmp, strerror);
 		talloc_free(tmp);
 	} else {