From: Vladimír Čunát <vladimir.cunat@nic.cz>
Date: Thu, 15 Nov 2018 15:45:12 +0000 (+0100)
Subject: CI lint:clang-scan-build - more error reductions
X-Git-Tag: v3.2.0~28^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ddb18ef6130eca4b3c98d07ea31a1f9cf3df6df8;p=thirdparty%2Fknot-resolver.git

CI lint:clang-scan-build - more error reductions
---

diff --git a/lib/cache/entry_rr.c b/lib/cache/entry_rr.c
index ec6e4b5ed..94dd0e83e 100644
--- a/lib/cache/entry_rr.c
+++ b/lib/cache/entry_rr.c
@@ -41,7 +41,7 @@ int rdataset_dematerialize(const knot_rdataset_t *rds, uint8_t * restrict data)
 		data += size;
 	}
 	//VERBOSE_MSG(NULL, "dematerialized to %d B\n", (int)(data - data0));
-	//return data - data0;
+	(void)data;
 	return kr_ok();
 }
 
diff --git a/tests/clang_scan_build.sh b/tests/clang_scan_build.sh
index 12831310e..8d7398fff 100755
--- a/tests/clang_scan_build.sh
+++ b/tests/clang_scan_build.sh
@@ -9,15 +9,15 @@ set -o errexit -o nounset
 # https://bugs.llvm.org/show_bug.cgi?id=3888
 
 # These are disabled for other reasons:
+# alpha.clone.CloneChecker # way too many false positives
+# alpha.core.CastToStruct # we use this pattern too much, hard to avoid in many cases
 # alpha.deadcode.UnreachableCode # false positives/flags sanity checks depending on implementation details
 # alpha.security.MallocOverflow # not smart enough to infer max values from data types
-# alpha.clone.CloneChecker # way too many false positives
 
 ${SCAN_BUILD:-scan-build} \
 -disable-checker  unix.Malloc \
 -enable-checker   alpha.core.BoolAssignment \
 -enable-checker   alpha.core.CallAndMessageUnInitRefArg \
--enable-checker   alpha.core.CastToStruct \
 -enable-checker   alpha.core.CastSize \
 -enable-checker   alpha.core.Conversion \
 -enable-checker   alpha.core.DynamicTypeChecker \