From: Frantisek Tobias <frantisek.tobias@nic.cz>
Date: Tue, 20 Jan 2026 17:20:54 +0000 (+0100)
Subject: daemon/session2/session2_transport_event(): remove kr_fails_assert
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ddb4d3b0fb4a32f3606de51fc2430efd7b2297c2;p=thirdparty%2Fknot-resolver.git

daemon/session2/session2_transport_event(): remove kr_fails_assert

When forwarding over DoT, an upstream that accepts a TCP connection
and immediately closes it triggers this assetion, because
the forwarder wasn't able to solve any waiting tasks.
---

diff --git a/daemon/session2.c b/daemon/session2.c
index 970e07a93..4052b202a 100644
--- a/daemon/session2.c
+++ b/daemon/session2.c
@@ -1756,10 +1756,8 @@ static int session2_transport_event(struct session2 *s,
 	bool is_close_event = (event == PROTOLAYER_EVENT_CLOSE ||
 			event == PROTOLAYER_EVENT_FORCE_CLOSE);
 	if (is_close_event) {
-		if (kr_fails_assert(session2_is_empty(s))) {
-			session2_waitinglist_finalize(s, KR_STATE_FAIL);
-			session2_tasklist_finalize(s, KR_STATE_FAIL);
-		}
+		session2_waitinglist_finalize(s, KR_STATE_FAIL);
+		session2_tasklist_finalize(s, KR_STATE_FAIL);
 		session2_timer_stop(s);
 		s->closing = true;
 	}