From: Chris Wright Date: Thu, 10 Feb 2011 06:11:51 +0000 (-0800) Subject: security: add cred argument to security_capable() X-Git-Tag: v2.6.32.69~21 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ddf5836aa820bf3b8c59ea3cca77881b41ca8d82;p=thirdparty%2Fkernel%2Fstable.git security: add cred argument to security_capable() commit 6037b715d6fab139742c3df8851db4c823081561 upstream. Expand security_capable() to include cred, so that it can be usable in a wider range of call sites. Signed-off-by: Chris Wright Acked-by: Serge Hallyn Signed-off-by: James Morris [wt: needed by next patch only] Signed-off-by: Willy Tarreau --- diff --git a/include/linux/security.h b/include/linux/security.h index d40d23fa576ad..73ebc3f608f1f 100644 --- a/include/linux/security.h +++ b/include/linux/security.h @@ -1733,7 +1733,7 @@ int security_capset(struct cred *new, const struct cred *old, const kernel_cap_t *effective, const kernel_cap_t *inheritable, const kernel_cap_t *permitted); -int security_capable(int cap); +int security_capable(const struct cred *cred, int cap); int security_real_capable(struct task_struct *tsk, int cap); int security_real_capable_noaudit(struct task_struct *tsk, int cap); int security_acct(struct file *file); @@ -1938,9 +1938,9 @@ static inline int security_capset(struct cred *new, return cap_capset(new, old, effective, inheritable, permitted); } -static inline int security_capable(int cap) +static inline int security_capable(const struct cred *cred, int cap) { - return cap_capable(current, current_cred(), cap, SECURITY_CAP_AUDIT); + return cap_capable(current, cred, cap, SECURITY_CAP_AUDIT); } static inline int security_real_capable(struct task_struct *tsk, int cap) diff --git a/kernel/capability.c b/kernel/capability.c index 8a944f528b97e..771618c63cba5 100644 --- a/kernel/capability.c +++ b/kernel/capability.c @@ -305,7 +305,7 @@ int capable(int cap) BUG(); } - if (security_capable(cap) == 0) { + if (security_capable(current_cred(), cap) == 0) { current->flags |= PF_SUPERPRIV; return 1; } diff --git a/security/security.c b/security/security.c index c4c673240c1c6..227b173cd55e4 100644 --- a/security/security.c +++ b/security/security.c @@ -151,10 +151,9 @@ int security_capset(struct cred *new, const struct cred *old, effective, inheritable, permitted); } -int security_capable(int cap) +int security_capable(const struct cred *cred, int cap) { - return security_ops->capable(current, current_cred(), cap, - SECURITY_CAP_AUDIT); + return security_ops->capable(current, cred, cap, SECURITY_CAP_AUDIT); } int security_real_capable(struct task_struct *tsk, int cap)