From: Stephen Finucane <stephen.finucane@intel.com>
Date: Sun, 6 Mar 2016 01:41:08 +0000 (+0000)
Subject: parsemail: Be consistent in variable naming
X-Git-Tag: v2.0.0-rc1~358
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=de16d6289786d41b119b4a7b4d041cab848a8ab2;p=thirdparty%2Fpatchwork.git

parsemail: Be consistent in variable naming

Don't refer to a variable using different names in different
locations unless there's a good reason to do so.

Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Andy Doan <andy.doan@linaro.org>
---

diff --git a/patchwork/bin/parsemail.py b/patchwork/bin/parsemail.py
index 3e2b9e83..16cd9d1b 100755
--- a/patchwork/bin/parsemail.py
+++ b/patchwork/bin/parsemail.py
@@ -149,15 +149,14 @@ def find_author(mail):
     if name is not None:
         name = name.strip()
 
-    new_person = False
-
+    save_required = False
     try:
         person = Person.objects.get(email__iexact=email)
     except Person.DoesNotExist:
         person = Person(name=name, email=email)
-        new_person = True
+        save_required = True
 
-    return (person, new_person)
+    return person, save_required
 
 
 def find_date(mail):